Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom ACME servers #186

Open
evilhamsterman opened this issue Nov 16, 2021 · 18 comments
Open

Support custom ACME servers #186

evilhamsterman opened this issue Nov 16, 2021 · 18 comments
Assignees
Labels
awaiting-approval Stale exempt

Comments

@evilhamsterman
Copy link

evilhamsterman commented Nov 16, 2021

linuxserver.io


Desired Behavior

Currently SWAG supports ZeroSSL and Let's Encrypt, that covers most of the situations, however there are more organizations starting to use internal ACME providers such as Step CA. SWAG should be able to use at least a basic custom provider url

Example

CERTPROVIDER=custom
CERTPROVIDERURL=https://internal-acme.server/acme

Current Behavior

Only two predefined ACME providers

Alternatives Considered

Maintaining a custom fork of SWAG

@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@evilhamsterman
Copy link
Author

As far as I'm aware this would still be a good idea

@tashian
Copy link

tashian commented Jan 10, 2022

+1

tashian added a commit to tashian/docker-swag that referenced this issue Jan 11, 2022
@tashian tashian mentioned this issue Jan 11, 2022
1 task
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@evilhamsterman
Copy link
Author

Still a thing

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@evilhamsterman
Copy link
Author

Is there a way we can keep this open without having to comment every month? As far as I'm aware this is still a thing and several people are interested.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@nemchik
Copy link
Member

nemchik commented Apr 13, 2022

Tagged as awaiting-approval. This will keep it open

@evilhamsterman
Copy link
Author

Thank you

tashian added a commit to tashian/docker-swag that referenced this issue Sep 26, 2022
tashian added a commit to tashian/docker-swag that referenced this issue Sep 26, 2022
tashian added a commit to tashian/docker-swag that referenced this issue Sep 26, 2022
tashian added a commit to tashian/docker-swag that referenced this issue Sep 26, 2022
@bokolob
Copy link

bokolob commented Jan 31, 2024

Hi guys! How can we get this merged?

@nemchik
Copy link
Member

nemchik commented Feb 1, 2024

If #371 is rebased it can be re-reviwed and likely merged.

@bokolob
Copy link

bokolob commented Feb 29, 2024

Hello! I've recreated PR, could anybody look at it?

@FackelAB
Copy link

FackelAB commented Jan 17, 2025

Will this issue ever get fixed? There were already three pull-request, but non of them are get merged.

@drizuid: Is there a way to get this issue solved?

@aptalca
Copy link
Member

aptalca commented Jan 18, 2025

One of those PRs was going to be merged but the OP disappeared and never rebased it. The other was a duplicate PR by someone random who didn't put any effort into it. The oldest one got lost in the shuffle when the image got a new maintainer and went through a huge restructuring.

This feature requires some extensive changes. It needs to be worked on closely with a contributor and thoroughly tested. That has not happened yet.

@bokolob
Copy link

bokolob commented Jan 18, 2025

Someone random - sounds a bot toxic :-(
It wa just a copy of abandoned pr with fresh master merged.

@aptalca
Copy link
Member

aptalca commented Jan 18, 2025

Didn't mean to offend. All I'm trying to say is, someone completely different than the original dev (someone I don't know, aka seemingly random) submitted an exact copy of the previous PR, which doesn't satisfy the criterion I listed above: It needs to be worked on closely with a contributor and thoroughly tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Stale exempt
Projects
None yet
6 participants