Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Setup.py about "building from source on ROCM" #572

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Setup.py about "building from source on ROCM" #572

wants to merge 4 commits into from
+23 −20

Conversation

hebiao064
Copy link
Collaborator

@hebiao064 hebiao064 commented Feb 20, 2025 •
edited
Loading

Summary

Closes: #538

pip3 install -e .[dev]

Setup succeeded on my cpu and h100 machine, need help from ROCm test.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@hebiao064 hebiao064 mentioned this pull request Feb 20, 2025
Open
@hebiao064
Copy link
Collaborator Author

hebiao064 commented Feb 20, 2025 •
edited
Loading

Need test from ROCM user: @tjtanaa
Feel free to modify my PR.

@tjtanaa
Copy link
Collaborator

tjtanaa commented Feb 20, 2025

Need test from ROCM user: @tjtanaa Feel free to modify my PR.

Sure. Let me look into this.

@hebiao064 hebiao064 marked this pull request as ready for review February 20, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue while building from source on ROCM
3 participants
@hebiao064 @tjtanaa @lancerts