Improve Hugging Face SFT Script #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's check whether |
There seems to be deprecated args in data preparation and will require a re-write. |
|
Can you help with that? |
Yes. Can you please help find the PRs/diff for the SFT Trainer like you have previously done here. That could be quite helpful:) |
|
You could use git blame and commit history on those module files to find relevant changes. |
yundai424
approved these changes
Feb 20, 2025
|
Hi @ParagEkbote Can you help me find where |
shivam15s
added a commit
that referenced
this pull request
Feb 21, 2025
This reverts commit 5476b20.
shivam15s
added a commit
that referenced
this pull request
Feb 21, 2025
This reverts commit 5476b20.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487
I've chosen to remove the deprecated parameter as previously mentioned in the issue. The sequence length for the training dataset can be specified using the HF datasets library as mentioned here.
Please let me know if any further rectification is required and I will make the necessary changes.
cc: @Tcc0403