Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic filter capabilities #6

Open
LaurenzV opened this issue Dec 14, 2024 · 2 comments
Open

Add basic filter capabilities #6

LaurenzV opened this issue Dec 14, 2024 · 2 comments

Comments

@LaurenzV
Copy link

Firstly, thanks for creating this tool! Will be pretty useful for me in the future. :D

I was wondering, are there any plans to add basic filtering capabilities in the report? The most basic one I can think of is being able to filter out image pairs that match so I can focus on the non-matching ones, but another thing that could be useful is the ability to filter images by name.

@LaurenzV
Copy link
Author

LaurenzV commented Dec 14, 2024

Ahh, nevermind, I realized that you can ignore matching files from the CLI! I guess the name filtering thing could still be useful though.

Perhaps it would still be useful to have some interactivity on the report page itself, but I understand if this is out of scope for this crate.

@spirali
Copy link
Collaborator

spirali commented Dec 15, 2024

Yes, you can ignore matching via --ignore-match. After your suggestion, I have also created PR #7 that adds --filter to CLI that allows to filter by name.

The interactivity is in the scope of this project. My nearest goal is to add some small JS to the report that would add some filtering and image zooming.

The bigger goal is to have interactive blessing. It is still in discussion how to do it, it would be nice to have a xillem app. I am also thinking about possibility to start a small rest service and make the HTML report more capable in "jupyter-like" style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants