Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on page SDL2/SDL_RenderSetVSync #459

Open
iloveclang opened this issue Feb 4, 2024 · 2 comments
Open

Feedback on page SDL2/SDL_RenderSetVSync #459

iloveclang opened this issue Feb 4, 2024 · 2 comments

Comments

@iloveclang
Copy link

It would be nice if there was some kind of explanation how to check if Vsync has actually been set

because, looking at the code, it appears that the function can only fail if the renderer check fails, or the int vsync argument is anything other than 0 or 1.

There appears to be no feedback on whether the vsync actually succeeded.

Is one supposed to check if (renderer->wanted_vsync || renderer->simulate_vsync ) ?

@icculus
Copy link
Contributor

icculus commented May 8, 2024

@slouken, is the vsync results checkable on SDL2? (and SDL3?)

@slouken
Copy link
Contributor

slouken commented May 9, 2024

No, it's guaranteed to work except on OpenGL, and if it fails in that case we'll simulate vsync, so it always succeeds from the perspective of the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants