Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide instructions on how to use MUI components with custom colors #580

Open
nebula-aac opened this issue Apr 25, 2024 · 2 comments
Open
Labels
kind/enhancement Improvement in current feature

Comments

@nebula-aac
Copy link
Contributor

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Mockups


Contributor Guide

@nebula-aac nebula-aac added the kind/enhancement Improvement in current feature label Apr 25, 2024
@nebula-aac nebula-aac changed the title Certain components display a white background, which it should be the theme's color Provide instructions on how to use MUI components with custom colors Apr 25, 2024
@surajgjadhav
Copy link
Contributor

Hi @nebula-aac ,
could you please elaborate more on this?
but we can override the MUI colors with our color codes,
if we want to override global Styles, we can follow this: https://mui.com/material-ui/customization/how-to-customize/#3-global-theme-overrides
I think this method is already in place in sistent code
you will also find other methods in same document

@nebula-aac
Copy link
Contributor Author

@surajgjadhav Thank you for suggestion, however majority of the global overrides is already done project specific.

What Sistent Design System is doing is creating a global theme provider that can be used anywhere in Layer5, and allow initializing the MUI theme provider. This is to lower duplication, and consolidate the conflicting styles, where we can call the styles from one place.

I will have to update this issue because your suggestion isn't what I am intended for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

No branches or pull requests

2 participants