Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Self hosted] Keep track of machine state to minimise waiting time #42

Open
hershd23 opened this issue Mar 15, 2022 · 4 comments
Open
Labels
issue/willfix This issue will be worked on kind/enhancement Improvement in current feature

Comments

@hershd23
Copy link
Contributor

Current Behavior

Currently we are arbitrarily waiting 10 minutes waiting for the server to get provisioned and started.

https://github.com/layer5io/meshery-smp-action/blob/20c0b6f64f4918c6ad2505810210e0480a409648/.github/workflows/scripts/start-cil-runner.sh#L27

Desired Behavior

We want to optimise on our waiting time by keeping track of the state variable by the machine

Implementation

The logic of this can look like

  • If "state" == "provisioning", sleep 10s...
  • If "state" == "active", echo "Machine successfully created!" and continue.
  • If "state" == "failed", echo "Failed to create machine" and exit.

in the above mentioned bash script.

A little experimentation might be required based on the intervals on which we poll. (We do not want cause anything that might come under a DOS attack :) )

Acceptance Tests

A link to the self-hosted workflow run would be key to get your changes accepted


Contributor Guide

@hershd23 hershd23 added the kind/enhancement Improvement in current feature label Mar 15, 2022
@gyohuangxin
Copy link
Member

Thank you for opening this issue and it's good to be thoughtful about time intervals. Can you look into this?

@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 30, 2022
@stale
Copy link

stale bot commented May 31, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed May 31, 2022
@gyohuangxin gyohuangxin reopened this May 31, 2022
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label May 31, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jul 30, 2022
@leecalcote leecalcote added the issue/willfix This issue will be worked on label Jul 30, 2022
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on kind/enhancement Improvement in current feature
Development

No branches or pull requests

3 participants