Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Academic Partners slider has a breaking animation during the starting few seconds #5805

Open
H-A-R-S-H-K opened this issue Aug 13, 2024 · 8 comments · May be fixed by #5966
Open

Academic Partners slider has a breaking animation during the starting few seconds #5805

H-A-R-S-H-K opened this issue Aug 13, 2024 · 8 comments · May be fixed by #5966
Assignees
@Tharanishwaran
Labels
help wanted Extra attention is needed kind/bug Something isn't working

Comments

@H-A-R-S-H-K
Copy link
Contributor

Description

Link: Home page
The Academic logos slider is breaking for first few seconds because of lazy loading.

Expected Behavior

It should have a smooth behaviour from the starting.

Video

Screen.Recording.2024-08-13.at.11.07.31.AM.mov

Environment:

Host OS: Mac OS
Browser: Chrome
@H-A-R-S-H-K H-A-R-S-H-K added the kind/bug Something isn't working label Aug 13, 2024
@H-A-R-S-H-K H-A-R-S-H-K mentioned this issue Aug 13, 2024
Closed
@Ashparshp
Copy link
Contributor

@H-A-R-S-H-K Please read the contributing guide and make sure to get assigned to issues. Wait for validation to confirm if the issues are valid or not. You can discuss the issues during the Monday website call. After opening the issues, you can wait for assignments and drop a message saying assign me if it's valid. Also, please read the contributing guide to avoid DCO issues, as you haven't signed both PRs. Please do so.

@Ashparshp Ashparshp added the help wanted Extra attention is needed label Sep 24, 2024
@Ashparshp
Copy link
Contributor

@jay270804, @Tharanishwaran, Anyone?

@Tharanishwaran
Copy link
Member

hi @Ashparshp can i work on this issue ?

@Ashparshp
Copy link
Contributor

Thank you, @Tharanishwaran. I've assigned it to you, go ahead!

@Tharanishwaran
Copy link
Member

@Ashparshp ,but in the issue mentioned Mac os

Environment:

Host OS: Mac OS
Browser: Chrome

But I use linux(ubuntu 22)

@Ashparshp
Copy link
Contributor

@Tharanishwaran, please check if it's working fine on your side or if it's a browser-specific or OS-specific issue. If everything looks good, then go ahead!

@Tharanishwaran
Copy link
Member

@Ashparshp, I’ve tested the Academic Partners slider on Ubuntu 22 in Chrome and Firefox, and the lazy loading issue still occurs in both. Can I go ahead and work on a fix?

@Ashparshp
Copy link
Contributor

Yes, @Tharanishwaran.

Thank you.

Tharanishwaran added a commit to Tharanishwaran/layer5 that referenced this issue Oct 2, 2024
@Tharanishwaran
Fix layer5io#5805: Remove loading message to improve animation in Aca…
bd429e8 
…demic Partners slider

Signed-off-by: Tharanishwaran <[email protected]>
@Tharanishwaran Tharanishwaran linked a pull request Oct 2, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tharanishwaran Tharanishwaran

Labels
help wanted Extra attention is needed kind/bug Something isn't working
Milestone
No milestone
3 participants
@Tharanishwaran @H-A-R-S-H-K @Ashparshp