Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sistent] Add Link component to the sistent components page #5947

Open
dragon-slayer875 opened this issue Oct 1, 2024 · 5 comments
Open
Assignees
Labels
framework/gatsby Gatsby related hacktoberfest Happy contributing! help wanted Extra attention is needed kind/enhancement New feature or request language/javascript Issues or pull requests that use Javascript or React language/markdown Issues or pull requests that use Markdown project/sistent

Comments

@dragon-slayer875
Copy link

dragon-slayer875 commented Oct 1, 2024

Current Behavior

Layer5 and it's projects use Sistent library to enable easy component reusability among our various projects.
One such component is Link.

Ideally, all sistent components are represented on https://layer5.io/projects/sistent/components, so a centralized usage and example documentation can be maintained. This will aid new developers to more quickly jump into contributing to the various projects.
The Link component currently needs this representation.

Desired Behavior

Proper documentation for Link component similar to Button component on https://layer5.io/projects/sistent/components
The documentation should include:

  • Explanation of the the function that the component serves in context of it's usage.
  • Code examples.
  • Stylistic guidelines to be followed while using the component in code (if any).

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@dragon-slayer875 dragon-slayer875 added kind/enhancement New feature or request help wanted Extra attention is needed hacktoberfest Happy contributing! language/javascript Issues or pull requests that use Javascript or React language/markdown Issues or pull requests that use Markdown framework/gatsby Gatsby related project/sistent labels Oct 1, 2024
@khushalsonawat
Copy link
Contributor

khushalsonawat commented Oct 7, 2024

Hi,
I'd like to work on this issue. Could you please assign it to me

@NishantSinghhhhh
Copy link
Contributor

Can you please assign this issue to me , I am motivated to work on this issue
@dragon-slayer875

@NishantSinghhhhh
Copy link
Contributor

@dragon-slayer875
I have added a PR for Links component PR number : #6012,can you please review it

@leecalcote
Copy link
Member

@NishantSinghhhhh have you opened a new PR?

@NishantSinghhhhh
Copy link
Contributor

@NishantSinghhhhh have you opened a new PR?

yes sir #6015 is the new PR for this issue , I am currently working on it to pass few tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/gatsby Gatsby related hacktoberfest Happy contributing! help wanted Extra attention is needed kind/enhancement New feature or request language/javascript Issues or pull requests that use Javascript or React language/markdown Issues or pull requests that use Markdown project/sistent
Development

No branches or pull requests

4 participants