Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Responsive issue in Docs pages #360

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

upsaurav12
Copy link

Description

This PR fixes #359

Notes for Reviewers
I have improved the alignment of containers that were look like this
image
And now after changes

image

Also improved footer's position as it was overlapping after i made some changes in some docs-pages

I also improved Css of https://getnighthawk.dev/docs/functionality/performance-benchmarking/
Now looking like this
image

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jul 24, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jul 24, 2024

Website preview ready!

Name Link
🔨 Latest commit 393431b
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/66ccb2614c804e0007677d8b
😎 Deploy Preview https://deploy-preview-360--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@upsaurav12
Copy link
Author

upsaurav12 commented Jul 24, 2024

I think we can also add toggle button for side-navbar because for width >= 575px the page does not have space in right side which is making the container less responsive so by adding toggle button we can utilize width of side-navbar

@upsaurav12
Copy link
Author

@Ashparshp can you review this PR ?

@Ashparshp
Copy link

Let's discuss in the evening call add as an agenda item, if you would:)

https://docs.google.com/document/u/0/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/mobilebasic

@upsaurav12
Copy link
Author

upsaurav12 commented Aug 26, 2024

@vishalvivekm @Ashparshp i have added some changes.
but a file of a name docs/_data/discuss/nighthawk.json was changed in the commit because i was resolving merge conflict on my commit.
what i should do to remove that changed file ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Poor styling in Home page and other page leading in misallignment of containers and element
2 participants