Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding space between the different components on website #290

Open
Vee339 opened this issue Apr 16, 2023 · 7 comments · May be fixed by #332
Open

Adding space between the different components on website #290

Vee339 opened this issue Apr 16, 2023 · 7 comments · May be fixed by #332
Assignees
@akhilender-bongirwar
Labels
area/website framework/jekyll

Comments

@Vee339
Copy link

Vee339 commented Apr 16, 2023

The website of getnighthawk is really great and UI is so smooth and appealing.

However, I feel that the components are a little close to each other. So, it would be great if we can add some margin-bottom to the analysis, distribution, and standards-based cards.
Moreover, it would be the cherry on the top if we can add space between Nighthawk & Meshery and Layer 7 Performance Analysis div.

layer5
layer5(1)

Contributor Resources
@welcome
Copy link

welcome bot commented Apr 16, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@Vee339
Copy link
Author

Vee339 commented Apr 16, 2023

Hi maintainers, I am waiting for your reply as I am so eager to work on this issue.

@Himral
Copy link

Himral commented Jun 1, 2023

Hi @Vee339 is this issue still open ? I can work on this

@Shivam-AfA
Copy link

@Vee339 Thanks for opening this issue. Yes, it seems that providing some space would be a good modification. You can make a PR for this and let's see the deploy preview in action. Please note that consistency is of utmost importance, so adding space in these sections means that other similar sections on the page will also need similar spacing.

@kituuu
Copy link

kituuu commented Aug 16, 2023

Is the issue still open?? Can I work on it?

@akhilender-bongirwar
Copy link
Member

Hey @leecalcote, I would like to work on this issue as there is no one assigned to it.

@leecalcote
Copy link
Member

I missed all the prior notifications here. Assigning...

akhilender-bongirwar added a commit to akhilender-bongirwar/getnighthawk that referenced this issue Aug 29, 2023
@akhilender-bongirwar
Enhanced Spacing for Improved Component Layout
5b7b892 
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.

Changes Made:
- Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability.
- Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance.

These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.

Resolves Issue: layer5io#290

Signed-off-by: Akhilender [email protected]
Closed
1 task
akhilender-bongirwar added a commit to akhilender-bongirwar/getnighthawk that referenced this issue Aug 30, 2023
@akhilender-bongirwar
Enhanced Spacing for Improved Component Layout
e1a5e71 
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.

Changes Made:
- Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability.
- Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance.

These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.

Resolves Issue: layer5io#290

Signed-off-by: Akhilender [email protected]
Signed-off-by: Akhilender <[email protected]>
akhilender-bongirwar added a commit to akhilender-bongirwar/getnighthawk that referenced this issue Aug 31, 2023
@akhilender-bongirwar
Enhanced Spacing for Improved Component Layout
b008390 
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.

Changes Made:
- Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability.
- Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance.

These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.

Resolves Issue: layer5io#290

Signed-off-by: Akhilender <[email protected]>
@akhilender-bongirwar akhilender-bongirwar linked a pull request Aug 31, 2023 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhilender-bongirwar akhilender-bongirwar

Labels
area/website framework/jekyll
Milestone
No milestone
6 participants
@leecalcote @kituuu @Vee339 @Shivam-AfA @Himral @akhilender-bongirwar