Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint to retrieve resources by resourceIdentifier #12044

Open
lahabana opened this issue Nov 14, 2024 · 1 comment · May be fixed by #12756
Open

Add endpoint to retrieve resources by resourceIdentifier #12044

lahabana opened this issue Nov 14, 2024 · 1 comment · May be fixed by #12756
Labels
kind/design Design doc or related kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Nov 14, 2024 •
edited
Loading

Description

We now have a systematic resourceIdentifier for everything.

There's a hash that should be computed from the resource Identifier. Is there a systematic way to compute the hash from a set of labels?

So could we have a new endpoint:

/meshes/<mesh>/<resourceType>/_resourceIdentifier/zones/<zoneName>/namespaces/<namespace>/name/<displayName>

These would always return the same as:

/meshes/<mesh>/<resourceType>/<hashedName>

This should be a MADR and this MADR should define:

  • resourceIdentifier
  • hashing algorithm from resourceIdentifier to resourceName
  • new api endpoint and how it should be implemented

This endpoint would enable the GUI to map from XDS config to resources and to hide altogether resourceNames to only rely on resourceIdentifier everywhere.

xref: kumahq/kuma-gui#2848
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature kind/design Design doc or related labels Nov 14, 2024
@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 18, 2024
@lobkovilya lobkovilya mentioned this issue Nov 18, 2024
Open
@lahabana lahabana mentioned this issue Nov 26, 2024
Merged
lahabana added a commit that referenced this issue Nov 29, 2024
@lahabana
feat(api): add short name support (#12109)
3aef2b2 
## Motivation

This adds short names that can be used in kubectl. It also creates a
path for the shortname to be also used in resource Identifier like in
XDS config for example.

## Implementation information

Add possibility to have shortname which is used in kubectl but also when
creating unique resource identifier

This is the first step in a multiple step of changes to make resource
identifier easier to use
## Supporting documentation

could help implem of: #12044

---------

Signed-off-by: Charly Molter <[email protected]>
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lobkovilya lobkovilya removed the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2025
@lobkovilya lobkovilya linked a pull request Feb 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/design Design doc or related kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(MADR): resource identifier format lobkovilya/kuma
2 participants
@lahabana @lobkovilya