Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unncessary i18nDir from hugo.toml #49643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unncessary i18nDir from hugo.toml #49643

wants to merge 2 commits into from

Conversation

SayakMukhopadhyay
Copy link
Contributor

@SayakMukhopadhyay SayakMukhopadhyay commented Feb 4, 2025 •
edited
Loading

Description

This PR removes the unnecessary i18nDir property from hugo.toml.

Issue

Closes: #49649

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 122d8ac
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b87400033e6d000815895a
😎 Deploy Preview https://deploy-preview-49643--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SayakMukhopadhyay SayakMukhopadhyay changed the title [WIP] Remove unncessary i18nDir from hugo-toml Remove unncessary i18nDir from hugo.toml Feb 5, 2025
@SayakMukhopadhyay SayakMukhopadhyay mentioned this pull request Feb 5, 2025
Open
@sftim
Copy link
Contributor

sftim commented Feb 5, 2025

Hmm, https://deploy-preview-49643--kubernetes-io-main-staging.netlify.app/bn/releases/ doesn't look happy does it? (compare https://kubernetes.io/bn/releases/)

@SayakMukhopadhyay
Copy link
Contributor Author

Nope, it seems like its not picking up the website defined localisation keys

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@SayakMukhopadhyay SayakMukhopadhyay force-pushed the i18n-symlink-fix branch 2 times, most recently from e9c823e to 178aab7 Compare February 10, 2025 07:00
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2025
@SayakMukhopadhyay
Copy link
Contributor Author

This PR is ready for review. It contains 55 file changes but most of them (52 files) are just the translations moving from data/i18n to i18n.

The other 3 files include 2 files for removing the OWNERS from data/i18n and adding it back to i18n (git doesn't consider it as a move) and the 3rd file is the update to the hugo.toml which adds hugo mounts to it.

@SayakMukhopadhyay SayakMukhopadhyay marked this pull request as ready for review February 10, 2025 08:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2025
sftim
sftim reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How confident are you that README and contributor docs changes are included here, @SayakMukhopadhyay ?

@SayakMukhopadhyay
Copy link
Contributor Author

How confident are you that README and contributor docs changes are included here, @SayakMukhopadhyay ?

@sftim They aren't. I was thinking about updating the README about the changes in here in a new PR, unless you would like to have them in this PR itself.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2025
sftim
sftim reviewed Feb 21, 2025
View reviewed changes
hugo.toml
@@ -517,3 +516,74 @@ languagedirection = "ltr"
languageNameLatinScript = "Tiếng Việt"
description = "Giải pháp điều phối container trong môi trường production"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a comment here, I think.
What happens if someone creates, eg i18n/de/en.toml?

The comment I have in mind warns people not to try that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Done!

sftim
sftim reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the individual localization directories should have filters that only match TOML files.

See https://www.kubernetes.dev/docs/guide/owners/#filters

@SayakMukhopadhyay
Copy link
Contributor Author

Maybe the individual localization directories should have filters that only match TOML files.

See https://www.kubernetes.dev/docs/guide/owners/#filters

Is there any possibility of the individual localisation directories containing anything other than the .toml files? I think any other file should be discouraged right? In which case, should we add a filter for OWNERS?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2025
@sftim
Copy link
Contributor

sftim commented Feb 21, 2025

Is there any possibility of the individual localisation directories containing anything other than the .toml files? I think any other file should be discouraged right? In which case, should we add a filter for OWNERS?

A team could make a mistake, or might update their OWNERS file (which we don't want).

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2025
@SayakMukhopadhyay
Copy link
Contributor Author

Is there any possibility of the individual localisation directories containing anything other than the .toml files? I think any other file should be discouraged right? In which case, should we add a filter for OWNERS?

A team could make a mistake, or might update their OWNERS file (which we don't want).

Agreed, I think we should do it in a fresh PR. There are a few changes in those OWNERS files (like https://github.com/kubernetes/website/blob/5de96d97b746cf156efd59ea343be08ff328048e/data/i18n/pl/OWNERS is missing the area/localization label).

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SayakMukhopadhyay
Copy link
Contributor Author

How confident are you that README and contributor docs changes are included here, @SayakMukhopadhyay ?

@sftim I have also added a commit in this PR to update the docs at https://kubernetes.io/docs/contribute/localization/ to reflect the changes. I think that's all there is regarding documentation around localisation. I will squash the commits into 2 commits, 1 for the changes and the other for the doc updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@salaxander salaxander Awaiting requested review from salaxander

@reylejano reylejano Awaiting requested review from reylejano

Assignees
No one assigned
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hugo doesn't properly use localisation keys
3 participants
@SayakMukhopadhyay @sftim @k8s-ci-robot