Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: fix wait --for=create to work correctly with label selectors #128662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kubectl: fix wait --for=create to work correctly with label selectors #128662

wants to merge 1 commit into from
+3 −1

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Nov 7, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes a bug in kubectl wait --for=create when used with label selectors (-l). Currently, the command exits immediately with "no matching resources found" instead of waiting for resources with matching labels to appear.

Example bug behavior:
Before the change, running this: kubectl wait --for=create pods -l app=myapp will exits immediately with error:
error: no matching resources found.
After this change: waits until matching pods appear or timeout:
error: timed out waiting for the condition

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1675

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed `kubectl wait --for=create` behavior with label selectors, to properly wait for resources with matching labels to appear.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign apelisse for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2024
@omerap12
Copy link
Member Author

omerap12 commented Nov 7, 2024

As I understand the bug exists because the code only handled the IsNotFound case and treated empty results (no label matches) as success, causing immediate exit. With this fix, we explicitly track whether any matching resources were found during the visit function so If no resources are found, it doesn't fail immediately but waits until the timeout.

@sftim
Copy link
Contributor

sftim commented Nov 7, 2024

Changelog tweak suggestion

-Fixed kubectl wait --for=create behavior with label selectors to properly wait for resources with matching labels to appear
+Fixed `kubectl wait --for=create` behavior with label selectors, to properly wait for resources with matching labels to appear.

@omerap12
Copy link
Member Author

omerap12 commented Nov 7, 2024

Changelog tweak suggestion

-Fixed kubectl wait --for=create behavior with label selectors to properly wait for resources with matching labels to appear

+Fixed `kubectl wait --for=create` behavior with label selectors, to properly wait for resources with matching labels to appear.

Sure. Will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@brianpursley brianpursley Awaiting requested review from brianpursley

Assignees
No one assigned
Labels
area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl wait --for=create doesn't work with selectors
3 participants
@omerap12 @k8s-ci-robot @sftim