Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl debug - allow to specify image pull secret #1671

Open
mb-stx opened this issue Oct 3, 2024 · 8 comments · May be fixed by kubernetes/kubernetes#128061
Open

Kubectl debug - allow to specify image pull secret #1671

mb-stx opened this issue Oct 3, 2024 · 8 comments · May be fixed by kubernetes/kubernetes#128061
Labels
area/api area/kubectl kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mb-stx
Copy link

mb-stx commented Oct 3, 2024

This is a Feature Request

What would you like to be added
Add new option to kubectl debug command to be able to specify image pull secret. Currently (v 1.31) there is only the option to specify image and image pull policy, but image pull secret is missing.

Why is this needed
When running in air-gapped environments images are pulled from internal repositories often by using credentials. In this case kubectl debug command is not usable, because image is not publicly available and it fails with ImagePull error. In general this will allow to debug pods in more restricted environments.

Comments

Thanks!

@mb-stx mb-stx added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 3, 2024
@dipesh-rawat
Copy link
Member

/transfer kubernetes

(Doesn't look like a docs issue)

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/website Oct 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 3, 2024
@mb-stx
Copy link
Author

mb-stx commented Oct 3, 2024

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2024
@SayakMukhopadhyay
Copy link

/area kubectl

@sgaist
Copy link

sgaist commented Oct 14, 2024

@chengjoey to the best of my knowledge, it does not belong to the API. Image pull secrets are at the pod level not the container so in this case it's rather a cli issue.

@chengjoey
Copy link

@chengjoey to the best of my knowledge, it does not belong to the API. Image pull secrets are at the pod level not the container so in this case it's rather a cli issue.

oh Yes, I mixed up the fields. I will delete my comment to avoid any impact. Thank you for your reply.

@ardaguclu
Copy link
Member

/transfer kubectl

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Oct 15, 2024
@ardaguclu
Copy link
Member

I dropped my comments about this issue in kubernetes/kubernetes#128061 (comment). I'll mark triage/accepted with a note that this requires an agreement on the KEP before any PR.

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/kubectl kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Needs Triage
Development

Successfully merging a pull request may close this issue.

7 participants