Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA: structured parameters #4381

Open
19 of 22 tasks
pohly opened this issue Jan 4, 2024 · 62 comments
Open
19 of 22 tasks

DRA: structured parameters #4381

pohly opened this issue Jan 4, 2024 · 62 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/batch Categorizes an issue or PR as relevant to WG Batch. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Milestone

Comments

@pohly
Copy link
Contributor

pohly commented Jan 4, 2024

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 4, 2024
@pohly
Copy link
Contributor Author

pohly commented Jan 4, 2024

/sig node
/wg batch

The rationale behind creating a separate KEP is that this is an extension of DRA that (at least in theory) could graduate at its own pace. The KEP document itself also will be shorter, which will make discussing it easier.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. wg/batch Categorizes an issue or PR as relevant to WG Batch. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 4, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 26, 2024
@pohly pohly changed the title DRA: numeric parameters DRA: semantic parameters Jan 31, 2024
@klueska
Copy link
Contributor

klueska commented Feb 7, 2024

/milestone v1.30
/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@klueska: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric
Copy link
Member

@SergeyKanzhelev can we get this added to the 1.30 milestone?

@johnbelamaric
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

@klueska: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/milestone v1.30
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.30

@salehsedghpour
Copy link

Hello @pohly 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

The status of this enhancement is marked as At risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@salehsedghpour salehsedghpour moved this to At Risk for Enhancements Freeze in 1.30 Enhancements Tracking Feb 8, 2024
@salehsedghpour
Copy link

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@salehsedghpour salehsedghpour moved this from At Risk for Enhancements Freeze to Tracked for Enhancements Freeze in 1.30 Enhancements Tracking Feb 9, 2024
@pohly pohly changed the title DRA: semantic parameters DRA: structured parameters Feb 9, 2024
@drewhagen
Copy link
Member

Hello @pohly 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Jan 12, 2025
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025
@dipesh-rawat dipesh-rawat removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 12, 2025
@haircommander haircommander moved this from Triage to Proposed for consideration in SIG Node 1.33 KEPs planning Jan 30, 2025
@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 30, 2025
@kannon92
Copy link
Contributor

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 31, 2025
@johnbelamaric johnbelamaric moved this from 📋 Backlog to 🏗 In progress in SIG Node: Dynamic Resource Allocation Feb 4, 2025
@dipesh-rawat
Copy link
Member

Hello @pohly 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Update the kep.yaml to reflect the following:
    • Add latest-milestone: v1.33.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
@haircommander haircommander moved this from Proposed for consideration to Considered for release in SIG Node 1.33 KEPs planning Feb 4, 2025
@pacoxu
Copy link
Member

pacoxu commented Feb 8, 2025

#4381 updated the GA graduation criteria for DRA structured parameters, like below.

  • At least 3 real-world driver implementations from different organizations
  • Standardization of at least one attribute suitable for intra-node topology alignment across drivers (e.g., NUMA or PCIe root, as determined to be appropriate and useful).
  • Allowing time for feedback
  • Scalability and performance analysis done and published

@pohly @johnbelamaric IIUC, this is not going to be GA in v1.33, right?
And the current status that this is beta in v1.32 but default off. Do we plan to make it by default on in v1.33?

new updates in v1.33 until now:

@pohly
Copy link
Contributor Author

pohly commented Feb 8, 2025

We cannot make it default on in 1.33 because the API group has to remain default off (Kubernetes policy).

There will be some minor enhancements of this feature in 1.33, but nothing that needs to be planned now through a KEP update.

@klueska
Copy link
Contributor

klueska commented Feb 8, 2025

We talked in the last working group meeting about updating this KEP in this cycle to include more comprehensive GA graduation criteria.

@dipesh-rawat
Copy link
Member

Hi @pohly 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4381 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@johnbelamaric
Copy link
Member

We talked in the last working group meeting about updating this KEP in this cycle to include more comprehensive GA graduation criteria.

Yes. I don't think it's critical to get it done before the KEP freeze though, it's just a punch list we need for 1.34, not changes going into 1.33 (some might, but they would be managed as separate issues). Some of them may need issues created.

@johnbelamaric
Copy link
Member

So, @pacoxu in other words there are no major changes here, we just wanted to track that we are working on it incrementally.

@dipesh-rawat
Copy link
Member

we just wanted to track that we are working on it incrementally.

@johnbelamaric, I’m wondering if we’ll still need a small change to the latest milestone (latest-milestone: "v1.33" in kep.yaml)) due to the incremental updates in v1.33 release cycle. Could you please confirm if that’s the case, or am I reading it wrong? Sorry for any confusion on my side!

@johnbelamaric
Copy link
Member

I’m wondering if we’ll still need a small change to the latest milestone

Yes, makes sense to me, thanks. Coming soon :)

@dipesh-rawat
Copy link
Member

Hello @pohly 👋, 1.33 Enhancements team here.

Now that PR #5160 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 11, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 11, 2025
@haircommander haircommander moved this from Considered for release to Tracked in SIG Node 1.33 KEPs planning Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/batch Categorizes an issue or PR as relevant to WG Batch. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: Tracked for Code Freeze
Status: Tracked for enhancements freeze
Status: Tracked
Status: 🏗 In progress
Status: Tracked for Doc Freeze
Status: Tracked for code freeze
Status: Done
Development

No branches or pull requests