-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
development.md#workflow should emphasize that local repo location is not optional #597
Comments
It would also be good to have findable documentation for the |
Mike, the documentation for bazel is here: https://github.com/kubernetes/community/blob/master/contributors/devel/bazel.md And it explains the requirement:
To update $ ./hack/update-bazel.sh NOTE: |
I agree to make the documentation more findable. It would be great to put a new chapter introducing bazel briefly in development workflow. /cc @bgrant0607 |
Emphasized that the local repo location is not optional. Added a pointer to the page about building with Bazel. Resolves kubernetes#597
Emphasized that the local repo location is not optional. Added a pointer to the page about building with Bazel. Resolves kubernetes#597
I used to be able to work on Kubernetes when its location on my laptop was
$GOPATH/src/github.com/${my github profile name}/kubernetes
(an obvious choice, IMO). Now that does not work. The location stated in https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#workflow --- namely$GOPATH/src/k8s.io/kubernetes
--- is required . If that location is not used then thehack/update-bazel.sh
script fails (e.g., see kubernetes/kubernetes#45263 (comment)). It would be good to update development.md#workflow to make it clear that the location it states MUST be used.The text was updated successfully, but these errors were encountered: