🐛 (helm/v1-alpha): Use namePrefix from config/default/kustomization.yaml as prefix for RBAC rules and project name only if this value cannot be found. #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
|
HI @mkarlheim Could you please check this one? |
camilamacedo86
force-pushed
the
use-prefix-name
branch
2 times, most recently
from
03a08a9 to
8775274
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
use-prefix-name
branch
from
8775274 to
e1b8916
Compare
camilamacedo86
commented
Feb 20, 2025
| @@ -255,7 +278,7 @@ func (s *initScaffolder) copyConfigFiles() error { | |||
|
|
|||
| // copyFileWithHelmLogic reads the source file, modifies the content for Helm, applies patches | |||
| // to spec.conversion if applicable, and writes it to the destination | |||
| func copyFileWithHelmLogic(srcFile, destFile, subDir, projectName string) error { | |||
| func copyFileWithHelmLogic(srcFile, destFile, subDir, namePrefix string) error { | |||
There was a problem hiding this comment.
HI @mkarlheim
Are there any other manifests that we should append this prefix and that we are missing?
…l as prefix for RBAC rules and project name only if this value cannot be found.
camilamacedo86
force-pushed
the
use-prefix-name
branch
from
e1b8916 to
bc1f6dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4566