Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Even when IRSA is used, pod still try IMDS when vpcId is not specified #3968

Open
1 task done
phuhung273 opened this issue Dec 5, 2024 · 2 comments
Open
1 task done
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@phuhung273
Copy link
Contributor

phuhung273 commented Dec 5, 2024

Is your feature request related to a problem?
Even when IRSA is used, default values for aws-region and aws-vpc-id are still autofilled using IMDS. Which is not achievable in secure environment, IMDS is encouraged to be disabled for pods.
image

By submitting this issue, Im fully aware that we can manually specify aws-region and aws-vpc-id so pods wont use IMDS.

Describe the solution you'd like
Default value: IRSA or IMDS

Idea:

cfs := config.LoadDefaultConfig()
region := cfg.Region
vpcID := eks.DescribeCluster().vpcID

Describe alternatives you've considered
N/A

  • I may able to contribute
@shraddhabang shraddhabang added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2024
@shraddhabang
Copy link
Collaborator

What should be default values in your opinion?

@phuhung273
Copy link
Contributor Author

@shraddhabang i just modified Issue to include the expected Default and idea for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants