-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider container image rename of kubeflow/storage-initializer
#2183
Comments
kubeflow/storage-initializer
Thanks for creating this @tarilabs! Yes, we might want to find better name (e.g. |
Yes agreed that we should have more unique names based on capabilities. |
shall we rename it to kubeflow/model-dataset-downloader ? |
I think that |
Yes, we might want to add |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
still valid imho. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
/reopen |
@tarilabs: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What you would like to be added?
This image: https://hub.docker.com/r/kubeflow/storage-initializer
from: https://github.com/kubeflow/training-operator/blob/master/sdk/python/kubeflow/storage_initializer/Dockerfile
is generically called:
kubeflow/storage-initializer
to integrate with KServe as a Custom Storage Initializer.Kindly consider renaming it something more specific to avoid end-user confusion?
Why is this needed?
From Model Registry,
we are also now producing a KServe CSI image: https://hub.docker.com/r/kubeflow/model-registry-storage-initializer
named specifically
kubeflow/model-registry-storage-initializer
to serve integration needs of Model Registry <-> KServe .
For more details, see this guide.
I believe making the image name specific to
<capability>-storage-initializer
will avoid confusion in the long term for Kubeflow end-users, also if other KF components will end up providing their own requirements of CSI !wdyt @andreyvelich @terrytangyuan ?
Love this feature?
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered: