Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider container image rename of kubeflow/storage-initializer #2183

Open
tarilabs opened this issue Jul 25, 2024 · 11 comments
Open

Consider container image rename of kubeflow/storage-initializer #2183

tarilabs opened this issue Jul 25, 2024 · 11 comments

Comments

@tarilabs
Copy link
Member

What you would like to be added?

This image: https://hub.docker.com/r/kubeflow/storage-initializer
from: https://github.com/kubeflow/training-operator/blob/master/sdk/python/kubeflow/storage_initializer/Dockerfile

is generically called: kubeflow/storage-initializer to integrate with KServe as a Custom Storage Initializer.

Kindly consider renaming it something more specific to avoid end-user confusion?

Why is this needed?

From Model Registry,
we are also now producing a KServe CSI image: https://hub.docker.com/r/kubeflow/model-registry-storage-initializer
named specifically kubeflow/model-registry-storage-initializer
to serve integration needs of Model Registry <-> KServe .

For more details, see this guide.

I believe making the image name specific to <capability>-storage-initializer will avoid confusion in the long term for Kubeflow end-users, also if other KF components will end up providing their own requirements of CSI !

wdyt @andreyvelich @terrytangyuan ?

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@tarilabs tarilabs changed the title Consider container image rename of Consider container image rename of kubeflow/storage-initializer Jul 25, 2024
@andreyvelich
Copy link
Member

Thanks for creating this @tarilabs! Yes, we might want to find better name (e.g. training-storage-initializer)
cc @johnugeorge @deepanker13

@terrytangyuan
Copy link
Member

Yes agreed that we should have more unique names based on capabilities.

@deepanker13
Copy link
Contributor

deepanker13 commented Aug 1, 2024

shall we rename it to kubeflow/model-dataset-downloader ?
cc @andreyvelich @terrytangyuan

@tenzen-y
Copy link
Member

tenzen-y commented Aug 2, 2024

shall we rename it to kubeflow/model-dataset-downloader ? cc @andreyvelich @terrytangyuan

I think that training- prefix would be better so that we can avoid conflicting with other projects.

@andreyvelich
Copy link
Member

Yes, we might want to add training-.
Additionally, after V2, we are planning to separate dataset-initializer and model-initializer in 2 different containers: #2171

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tarilabs
Copy link
Member Author

still valid imho.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@tarilabs
Copy link
Member Author

/reopen

@google-oss-prow google-oss-prow bot reopened this Feb 19, 2025
Copy link

@tarilabs: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants