Skip to content
This repository has been archived by the owner on Jun 12, 2021. It is now read-only.

Required parameters #13

Open
kashav opened this issue Nov 2, 2016 · 4 comments
Open

Required parameters #13

kashav opened this issue Nov 2, 2016 · 4 comments
Assignees
@kashav
Labels
docs enhancement

Comments

@kashav
Copy link
Member

kashav commented Nov 2, 2016 •
edited
Loading

Find the required parameters for each of the nba.stats endpoints and make that parameter bold.

Most stats.nba.com endpoints will throw an error if a required parameter is missing, so we can use this to find the list of required params.

e.g. Making a request to http://stats.nba.com/stats/commonallplayers without any parameters will return:

LeagueID is required; Season is required; IsOnlyCurrentSeason is required

So the documentation for the data.stats.allPlayers method should look like:
@kashav
Copy link
Member Author

kashav commented Nov 2, 2016 •
edited
Loading

List of endpoint URLs:

@kashav kashav self-assigned this Nov 2, 2016
@mihaisavezi
Copy link
Contributor

@kashav
Copy link
Member Author

kashav commented Mar 28, 2018

@mihaisavezi, nice find! Wanna submit a PR to add it to the library? 😀

@anich003
Copy link

Have you seen the template repo here? Specifically, the file nba.json seems to have alot (if not all) of these endpoints with their required parameters listed, as well as the set of parameters with their default values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kashav kashav

Labels
docs enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mihaisavezi @kashav @anich003