-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular dependencies in LESS imports cause AssetFactory::getLastModified() to enter an infinite loop #881
Comments
@dunets I'm glad I was able to provide some amusement for you 😝 😄 |
LukeTowers
added a commit
to octobercms/october
that referenced
this issue
Jul 6, 2018
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
octoberapp
pushed a commit
to octoberrain/system
that referenced
this issue
Jul 7, 2018
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
LukeTowers
added a commit
to octoberrain/system
that referenced
this issue
Mar 24, 2019
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
LukeTowers
added a commit
to octoberrain/system
that referenced
this issue
Apr 20, 2019
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
@jaxwilko this is the issue I was talking about. Could you see if it still happens with the wikimedia package we're using instead? |
@jaxwilko did you ever get a chance to see if this is still present in wikimedia? |
@LukeTowers I think I had a look but I can't remember what the outcome was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AssetFactory->getLastModified() does not take into account circular dependencies when attempting to get the lastModified time for the provided asset using dependency resolving. If
loopstart.less
importsloopstep.less
andloopstep.less
includesloopstart.less
; then it will result in an infinite loop when trying to get the last modified time for the tree as a whole.loopstart.less
loopstep.less
The text was updated successfully, but these errors were encountered: