Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies in LESS imports cause AssetFactory::getLastModified() to enter an infinite loop #881

Open
LukeTowers opened this issue Apr 18, 2018 · 4 comments

Comments

@LukeTowers
Copy link

AssetFactory->getLastModified() does not take into account circular dependencies when attempting to get the lastModified time for the provided asset using dependency resolving. If loopstart.less imports loopstep.less and loopstep.less includes loopstart.less; then it will result in an infinite loop when trying to get the last modified time for the tree as a whole.

loopstart.less

@import "loopstep.less";

loopstep.less

@import "loopstart.less";
@LukeTowers
Copy link
Author

@dunets I'm glad I was able to provide some amusement for you 😝 😄

LukeTowers added a commit to octobercms/october that referenced this issue Jul 6, 2018
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
octoberapp pushed a commit to octoberrain/system that referenced this issue Jul 7, 2018
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
LukeTowers added a commit to octoberrain/system that referenced this issue Mar 24, 2019
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
LukeTowers added a commit to octoberrain/system that referenced this issue Apr 20, 2019
Removes a circular dependency from windex.variables.less that triggers kriswallsmith/assetic#881.
@LukeTowers
Copy link
Author

@jaxwilko this is the issue I was talking about. Could you see if it still happens with the wikimedia package we're using instead?

@LukeTowers
Copy link
Author

@jaxwilko did you ever get a chance to see if this is still present in wikimedia?

@jaxwilko
Copy link

@LukeTowers I think I had a look but I can't remember what the outcome was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants