From 284422b1841c17503deb403da49d051f17547f7f Mon Sep 17 00:00:00 2001
From: Ryan Olds <ryanrolds@gmail.com>
Date: Tue, 5 Nov 2024 11:31:08 -0800
Subject: [PATCH] Switch Tilt image pull policy to IfNotPresent (#10279)

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
---
 Tiltfile                                                      | 4 ++--
 changelog/v1.18.0-beta32/tilt-pull-policy-if-not-present.yaml | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100644 changelog/v1.18.0-beta32/tilt-pull-policy-if-not-present.yaml

diff --git a/Tiltfile b/Tiltfile
index 51cb5978750..6e7f1bf1d4e 100644
--- a/Tiltfile
+++ b/Tiltfile
@@ -55,7 +55,7 @@ RUN chmod 777 ./$binary_name
 standard_entrypoint = "ENTRYPOINT /app/start.sh /app/$binary_name"
 debug_entrypoint = "ENTRYPOINT /app/start.sh /go/bin/dlv --listen=0.0.0.0:$debug_port --api-version=2 --headless=true --only-same-user=false --accept-multiclient --check-go-version=false exec --continue /app/$binary_name"
 
-get_resources_cmd = "{0} -n {1} template {2} --include-crds install/helm/gloo/ --set gloo.deployment.image.pullPolicy='Always' --set license_key='abcd'".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
+get_resources_cmd = "{0} -n {1} template {2} --include-crds install/helm/gloo/ --set gloo.deployment.image.pullPolicy='IfNotPresent' --set license_key='abcd'".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
 for f in settings.get("helm_values_files") :
     get_resources_cmd = get_resources_cmd + " --values=" + f
 get_resources_cmd = get_resources_cmd + " --set=gloo.deployment.livenessProbeEnabled=false"
@@ -197,7 +197,7 @@ def install_gloo():
     if not gloo_installed :
         install_helm_cmd = """
             kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || {{ kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.1.0/standard-install.yaml; }} ;
-            {0} upgrade --install -n {1} --create-namespace {2} install/helm/gloo/ --set gloo.deployment.image.pullPolicy='Always' --set license_key='$GLOO_LICENSE_KEY' --set gloo.deployment.glooContainerSecurityContext.readOnlyRootFilesystem=false""".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
+            {0} upgrade --install -n {1} --create-namespace {2} install/helm/gloo/ --set gloo.deployment.image.pullPolicy='IfNotPresent' --set license_key='$GLOO_LICENSE_KEY' --set gloo.deployment.glooContainerSecurityContext.readOnlyRootFilesystem=false""".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
         for f in settings.get("helm_values_files") :
             install_helm_cmd = install_helm_cmd + " --values=" + f
         install_helm_cmd = install_helm_cmd + " --set=gloo.deployment.livenessProbeEnabled=false"
diff --git a/changelog/v1.18.0-beta32/tilt-pull-policy-if-not-present.yaml b/changelog/v1.18.0-beta32/tilt-pull-policy-if-not-present.yaml
new file mode 100644
index 00000000000..c413256e14c
--- /dev/null
+++ b/changelog/v1.18.0-beta32/tilt-pull-policy-if-not-present.yaml
@@ -0,0 +1,3 @@
+changelog:
+  - type: NON_USER_FACING
+    description: Adjusted pull policy in Tiltfile to `IfNotPresent`. Addresses issue with images being not found in local dev.