Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing direct dependency on npx #316

Closed
ballPointPenguin opened this issue Mar 10, 2021 · 4 comments
Closed

Consider removing direct dependency on npx #316

ballPointPenguin opened this issue Mar 10, 2021 · 4 comments

Comments

@ballPointPenguin
Copy link

The distributed npx library is deprecated and now is handled within the npm distribution.
https://github.com/npm/npx#readme

This means that the npx library being required here will be stuck at v10.2, which in turn requires npm 5.x, which (I think) is sometimes causing problems with ember-cli-update because it uses an older version of graceful-fs.

I realize this is a long cause-and-effect chain of my insinuation. I am experiencing cb.apply is not a function when trying to run ember-cli-update, and so far this is the best guess that I have.

@ballPointPenguin
Copy link
Author

Related to ember-cli/ember-cli-update#1105

@kellyselden
Copy link
Owner

I think enough time has progressed, and we can assume npx is already on the machine. I think we can remove it.

@aberres
Copy link

aberres commented Feb 13, 2023

@kellyselden Out of curiosity, I ended up here when looking into why we install an old deprecated tar. Any plans to drop the dependency?

@kellyselden
Copy link
Owner

I'm open to the change, but I'm not planning on doing the work myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants