Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Incompatibility with Effect Macro and Active Token Effects #322

Open
maxobremer opened this issue Jun 19, 2024 · 1 comment
Open

Comments

@maxobremer
Copy link

Describe the bug
When using an aura that ignores self, the effects related to Effect Macro and Active Token Effects still apply to self. If its an Effect Macro then the token where the aura originates from still triggers the macros set up with Effect Macro and if the aura has an effect that causes light to emit from the token, the token the aura originates from also emits light even though ignore self is on.

To Reproduce
Steps to reproduce the behavior:

  1. Enable Active Auras and either or both of the other modules
  2. give a token an active effect that is an aura that ignores self
  3. have the aura either use Effect Macro (like an On Attack Roll trigger macro) or Active Token Effects (like attribute key ATL.light.bright set to 10)
  4. If using Effect Macro, make the token the aura originates from trigger the macro. If using Active Token Effects, notice the effect on the token

Expected behavior
I expect that if ignore self is enabled that it whatever Effect Macro and Active Token Effects do is ignored on self.

Screenshots
In this screenshot you can see that both tokens glow red using Active Token Effects, even though the aura is set to ignore self, so the bottom token should not glow. Also the aura should only effect enemies, so that is another reason why it shouldnt effect the bottom token, since Riswynn the dwarf rogue is not an enemy of Riswynn the dwarf rogue
image
Its a bit harder to show with Effect Macro in a screenshot, but the 1d4 damage roll in chat were caused by an On Attack Roll effect macro
image

Environment:

  • OS: windows 10?
  • Browser Foundry itself
  • Foundry Version V12.327
  • Module Version 0.9.1.3
  • All Modules Disabled: No
  • Module List if no:
    • Active Token Effects (v0.8.0)
    • Effect Macro (12.1.0)
    • LibWrapper (1.12.13.1)
    • socketlib (1.0.13)

Additional context
good job on the module so far.

@MrPrimate
Copy link
Collaborator

For ATL/ATE at least this is due to the way it decides which effects on an actor to apply. I have had a chat with the maintainor, but not sure there is an easy answer right now. I assume Effect Macro works in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants