Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10 Errors Transferring Effect to Template #264

Open
TogaParty opened this issue Feb 5, 2023 · 1 comment
Open

v10 Errors Transferring Effect to Template #264

TogaParty opened this issue Feb 5, 2023 · 1 comment

Comments

@TogaParty
Copy link

Describe the bug
Error transferring effect to template. This works in v9, but fails in v10:
Uncaught (in promise) TypeError: undefined. Cannot read properties of undefined (reading 'tag')
[Detected 1 package: itemacro]
at eval (eval at Item._executeScript (helper.js:82:18), :6:12)
at Macro.eval (eval at Item._executeScript (helper.js:82:18), :9:9)
at Item._executeScript (helper.js:88:12)
at Item.executeMacro (helper.js:60:23)
at HTMLDivElement. (helper.js:170:20)
at HTMLDivElement.dispatch (jquery.min.js:2:43064)
at y.handle (jquery.min.js:2:41048)

'tag' seems like it may be related to tagger (installed, enabled, and latest version).

Module requirements met: Advanced Macros, Midi-QOL, DAE, Item Macro, etc.

To Reproduce
Steps to reproduce the behavior:

  1. Configure aura
  2. Configure to transfer to template (code below,, from the AA compendium)

if (!game.modules.get("advanced-macros")?.active) { ui.notifications.error("Advanced Macros is not enabled"); return }
if(args[0].tag === "OnUse"){
AAhelpers.applyTemplate(args)
}

Expected behavior
Aura effect on template.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Foundry Version [e.g. 0.8.8]
  • Module Version [e.g 0.1.42]
  • All Modules Disabled: Yes/No
  • Module List if no:

Additional context
Add any other context about the problem here.

@MrPrimate
Copy link
Collaborator

This definitely works, and works for my Spike Growth macro attached to a template. Worth noting I had difficulties getting it working on anything other than a "preActiveEffects" on use macro.

If it still doesn't work, can your provide a copy of the item, and try with just the prerequisite modules installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants