Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action Deprecation notices #2196

Closed
4 tasks
jameslnewell opened this issue Oct 17, 2022 · 3 comments · Fixed by #2221
Closed
4 tasks

Github Action Deprecation notices #2196

jameslnewell opened this issue Oct 17, 2022 · 3 comments · Fixed by #2221

Comments

@jameslnewell
Copy link

jameslnewell commented Oct 17, 2022

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the Codegen and plugins version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

Github Actions are reporting some impending deprecations and changes that could affect functionality.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: kamilkisiela/graphql-inspector
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

To Reproduce Steps to reproduce the behavior:

Add the action to a workflow

name: Check GraphQL Schema

on:
  pull_request:
    branches:
      - main

jobs:
  check-graphql-schema:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@master
        
      - uses: kamilkisiela/[email protected]
        with:
          schema: 'main:schema.graphql'

Expected behavior

Deprecations don't show

Environment:

  • OS: ubuntu-latest
  • @graphql-inspector/...: 3.4.0
  • graphql: -
  • NodeJS: 12

Additional context

@NikitaSmithTheOne
Copy link

I have the same situation. Github's changelog may be helpful.

@nathanchapman
Copy link
Contributor

@TuvalSimha what about #2370? I think #2221 only partially addresses this issue

@Bertg
Copy link

Bertg commented Jul 26, 2023

We are running the latest version available via the GitHub market place. This means it is v3.4.0.

This version still contains the issue describe din this ticket. When will there be an official, versioned release on the market place? Or has this project decided to only support @master for actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants