Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate useScrictLang in DayRepository->getDaysForListType, getSubQueryBuilder #428

Open
derBoogie opened this issue Jul 10, 2023 · 1 comment

Comments

@derBoogie
Copy link

derBoogie commented Jul 10, 2023

After the update to v8 of Events2 the translated page (EN) shows the events from the default language (DE) if no translated events are currently available. I would like to show a message like "No events found" instead.
This can be done if the param $useScrictLang is set to true in DayRepository->getDaysForListType $subQueryBuilder = $this->getSubQueryBuilder($queryBuilder, true); in line 91.
Can you add a condition to set this param?

@sfroemkenjw
Copy link
Contributor

Hello @derBoogie

seems that doOverlay here is TRUE which leads to the wrong results:
https://github.com/jweiland-net/events2/blob/main/Classes/Helper/OverlayHelper.php#L136

doOverlay should be FALSE, if you have configured strict mode. So, for now, there seems to be a miss-configuration in your system.

PS: I prefer to use one of these EventListeners in DayRepository to adapt all these Queries to your needs

PS: All these Queries will be re-factored again within the next big release.

Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants