Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clan character description limit of 500 is not enforced. #95

Open
Noeda opened this issue May 27, 2024 · 0 comments
Open

Clan character description limit of 500 is not enforced. #95

Noeda opened this issue May 27, 2024 · 0 comments

Comments

@Noeda
Copy link
Collaborator

Noeda commented May 27, 2024

https://junethack.net/clan/11111111111111111111111111111

Crafted one that has len(description) == 10000.

I think it's only enforced on the UI browser side, but if you bypass that and send it off wire, it'll accept anything. It seem like the line in clan.rb property :description, String, length: 500, :default => "" the length is not actually something that is enforced.

I'd dig deeper but as I'm writing this I have to run off for errands. I worry that if that's not enforced, are the other places where length: is specified more like a suggestion than an actually validated limit. My first guess is that it's mapped directly to SQL, and Sqlite3 will not enforce anything for you. But not sure. That would be first thing I'd educate myself on how this stuff is mapped to underlying DB stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant