Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Grid selector #4006

Open
10 tasks done
JE-Amouel opened this issue Sep 23, 2024 · 4 comments
Open
10 tasks done

[FEATURE REQUEST] Grid selector #4006

JE-Amouel opened this issue Sep 23, 2024 · 4 comments

Comments

@JE-Amouel
Copy link

JE-Amouel commented Sep 23, 2024

Checklist

  • I have read through the manual page (man fzf)
  • I have searched through the existing issues
  • For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

future

OS

  • Linux
  • macOS
  • Windows
  • Etc.

Shell

  • bash
  • zsh
  • fish

Problem / Steps to reproduce

Hi,
first of all thank you for bringing this ray of sunshine that is fzf to our terminals,

However, I have a request which, if you allow me, would only make me even more joyful in this cold space that the final year can sometimes be,

Well, I noticed that the only possible arrangement that the selector offers is a vertical selection where all the hot spots are aligned from bottom to top,
however this can be quite restrictive in most of my use cases,

Would it be possible to have a grid layout?
we could select the number of lines and the number of columns to display.

THANKS.

@JE-Amouel
Copy link
Author

👋 Hi

@junegunn
Copy link
Owner

junegunn commented Feb 6, 2025

I didn't respond to your three requests because they require significant changes to the code and I didn't and don't have the bandwidth to do it. Also because fzf currently has so many options for customizing how the list section is displayed, it is not clear if we could ever make them compatible with the new suggested layout. I could mark these issues wontfix and close them, but I decided to keep them open, because I might revisit them in the future. But it's almost certainly not going to happen soon. If you mind keeping them open, feel free to close them.

There was a similar request in the past, and I declined because of the same reason. It's just too much work. It's even more so now because of many new additions since then, such as multi-line support, separate borders for each section, etc.

@JE-Amouel
Copy link
Author

I didn't respond to your three requests because they require significant changes to the code and I didn't and don't have the bandwidth to do it.

I understand that you must have had a lot on your plate, and that is why I thank you for taking the time to answer me despite all your busyness.

Also because fzf currently has so many options for customizing how the list section is displayed, it is not clear if we could ever make them compatible with the new suggested layout.

I completely understand, fzf is already in its state the most customizable program and among the most useful in all categories and for me has become the example of a program with Unix DNA, it doesn't matter if it doesn't pass, the main thing is to have received feedback from you, know that I appreciate it.

I could mark these issues wontfix and close them, but I decided to keep them open, because I might revisit them in the future. But it's almost certainly not going to happen soon. If you mind keeping them open, feel free to close them.

Listen, you're the boss, it's your project, I'm just happy that often the geniuses we love share their work, don't take it badly if I go over it again, far from me the idea of ​​having wanted to be disturbing.

There was #1476, and I declined because of the same reason. It's just too much work. It's even more so now because of many new additions since then, such as multi-line support, separate borders for each section, etc.

What you are already doing is remarkable and very appreciated, and know that we will perhaps never thank you enough for all these efforts to maintain this wonderful tool which is the darling of the community,
And yourself said it, maybe you will do it one day, and for me it touches me a lot because despite all the challenge that it could generate, you are still ready to consider it, and just for that,
thank you.🙏

@junegunn
Copy link
Owner

junegunn commented Feb 6, 2025

Thanks for the kind words, and for understating. I don't disagree with your suggestions – they are certainly nice to have – but there are significant technical hurdles to implementing them, and they would add considerable complexity to the code that is already too complex to my liking, so we should carefully evaluate if they're worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants