Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Default to using https if protocol is not specified #451

Open
ronnypmuliawan opened this issue Nov 1, 2024 · 0 comments
Open

Comments

@ronnypmuliawan
Copy link

Context

We were using Auth0 and this library to handle OIDC login. Recently Auth0 rolled a change that prevent apps from calling them via plaintext (see https://community.auth0.com/t/action-required-always-use-https-for-communication-with-auth0/145203)

As we did not specify the protocol (it was misconfigured since the first ever deployment 5 years ago), we were hit with downtime as users were not able to login and needed the debug the issue.

Suggestion

As https is the de facto standard for all authentication matters, in the absence of specified protocol, I will recommend the library to default to https and log an error or warning that the https should be specified.

Alternatively, throw an error if protocol is not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant