Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage has dipped below 100% #268

Open
domenic opened this issue Nov 5, 2023 · 0 comments
Open

Coverage has dipped below 100% #268

domenic opened this issue Nov 5, 2023 · 0 comments

Comments

@domenic
Copy link
Member

domenic commented Nov 5, 2023

You can generate a coverage report after doing npm install with npm coverage, then opening coverage/index.html.

  • canParse with a non-parseable base URL
  • setters:
    • cannot have a username/password/port for username/password/port setter
    • has an opaque path for host/hostname/pathname setter
    • port set to the empty string
    • hash set to the empty string
    • potentially string trailing spaces from an opaque path early-return case where query !== null
  • main state machine:
    • ends in a number checker early return where part's size is 1
    • any cases of "includes credentials" where username === ""
    • various early returns and other special handling in the state override of the scheme state parser
    • some state override cases in the host/hostname parser
    • some state override cases in the file host parser
    • state override case in the path start parser

/cc @annevk in case you want to work on this in preparation for Interop 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant