Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): use corepack when setting up node in CI #184

Closed
jordanshatford opened this issue Nov 1, 2023 · 0 comments
Closed

feat(ci): use corepack when setting up node in CI #184

jordanshatford opened this issue Nov 1, 2023 · 0 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@jordanshatford
Copy link
Owner

jordanshatford commented Nov 1, 2023 •
edited
Loading

Describe the problem

Current CI uses PNPM action to setup the version of PNPM

Describe the proposed solution

Instead we should setup Node with corepack to use the package manager specified in our package.json. This will also ensure the expected version is installed.

Alternatives considered

No response

Importance

nice to have

Additional information

setup node action ticket ref: actions/setup-node#531

new PR: actions/setup-node#901
@jordanshatford jordanshatford added the enhancement New feature or request label Nov 1, 2023
@jordanshatford jordanshatford self-assigned this Nov 1, 2023
@jordanshatford jordanshatford removed their assignment Nov 19, 2023
@jordanshatford jordanshatford added the github_actions Pull requests that update GitHub Actions code label Nov 21, 2023
@jordanshatford jordanshatford self-assigned this Nov 24, 2023
@jordanshatford jordanshatford removed their assignment Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordanshatford