Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit status on communication failures #37

Open
danwinship opened this issue Feb 1, 2017 · 1 comment
Open

exit status on communication failures #37

danwinship opened this issue Feb 1, 2017 · 1 comment

Comments

@danwinship
Copy link

Currently omping only exits with non-0 status if there are problems with the command line.

When using -c or -T it seems like it should also exit with an error if either (a) it doesn't manage to communicate with a given host before the timeout, or (b) it manages to communicate with the host via unicast but not via multicast.

(I'm working on an end-to-end test of multicast connectivity between containers in OpenShift. omping is nice for this because omping -c 1 will exit quickly in the case where unicast works but multicast doesn't, rather than forcing us to guess an appropriate timeout.)

@jfriesse
Copy link
Owner

jfriesse commented Feb 2, 2017

@danwinship First of all, good catch, thanks.

I can fully agree with (a).

(b) is little more problematic because building multicast tree can take a longer time and it's not unusual that first few multicast packets are lost. But I believe it's possible to use adjusted_loss and if it is 0, it's perfectly legal to return success.

I'll try to make some patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants