Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for options including publishResultAs, scmVars, etc #78

Open
codeocelot opened this issue Sep 15, 2019 · 1 comment
Open

Comments

@codeocelot
Copy link

Hi maintainers!

First, thanks for publishing this plugin. It's been a great help to my team's workflow.

While using this plugin, I found the README documentation pretty unhelpful because it didn't explain the available options for the plugin. In fact, the documentation does not produce the expected results in at least one case-- publishResultsAs is always defined as statusCheck throughout the README, but the screenshot at the top of the docs corresponds to publishResultsAs: 'comment'.

Additionally, scmVars is undocumented and it's not intuitive that GIT_BRANCH, GIT_COMMIT need to be provided to discover the PR.

It may be helpful to add further documentation beyond this, but these are the pain-points I discovered and only resolved by diving into the plugin source (and after many failed Jenkins jobs!)

As to a resolution, I'm happy to submit a PR to add these sections to the README if the maintainers are in support of that. Just let me know.

@dmotpan
Copy link
Collaborator

dmotpan commented Sep 24, 2019

hey @codeocelot
Feel free to submit a PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants