From d006926a272c49919b798c85ed5e6be9b0f331d5 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Thu, 31 Oct 2024 12:52:49 +0530 Subject: [PATCH 1/8] Use Node v20 via `actions/setup-node@v4` --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a641d512..d4756bce 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,12 +38,12 @@ jobs: strategy: fail-fast: false matrix: - node_version: ["12"] + node_version: ["20"] steps: - name: Checkout Repository uses: actions/checkout@v4 - name: "Set up Node ${{ matrix.node_version }}" - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node_version }} cache: "yarn" From 934183f618593e53cd99b476b70a1fb0330bfca3 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 4 Dec 2024 20:09:45 +0530 Subject: [PATCH 2/8] Replace `node-sass` with `sass-embedded` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3505602a..fd413235 100644 --- a/package.json +++ b/package.json @@ -65,7 +65,6 @@ "lint-staged": "^4.3.0", "moment-locales-webpack-plugin": "^1.1.2", "nock": "10.0.6", - "node-sass": "4.13.1", "npm-run-all": "4.1.5", "prettier": "^1.19.1", "react-addons-test-utils": "15.4.1", @@ -75,6 +74,7 @@ "react-test-renderer": "15.4.1", "redux-immutable-state-invariant": "1.2.4", "redux-mock-store": "^1.0.4", + "sass-embedded": "^1.80.0", "webpack-bundle-analyzer": "^3.6.0" }, "browserslist": { From da1fed1b82caf6e3be5f5528d82979eb527b0550 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 4 Dec 2024 20:35:58 +0530 Subject: [PATCH 3/8] Install Python in Node test environment --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d4756bce..c333513b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,6 +42,10 @@ jobs: steps: - name: Checkout Repository uses: actions/checkout@v4 + - name: "Set up Python" + uses: actions/setup-python@v5 + with: + python-version: "3.14" - name: "Set up Node ${{ matrix.node_version }}" uses: actions/setup-node@v4 with: From 5a150a1039bd158b2b030b20bd7f552ad04f7236 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 4 Dec 2024 20:38:09 +0530 Subject: [PATCH 4/8] Install Python 3.13 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c333513b..64704dd9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,7 +45,7 @@ jobs: - name: "Set up Python" uses: actions/setup-python@v5 with: - python-version: "3.14" + python-version: "3.13" - name: "Set up Node ${{ matrix.node_version }}" uses: actions/setup-node@v4 with: From bea6e7669e269b39ab9cd89e263d2c74fb774d3f Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 4 Dec 2024 20:50:50 +0530 Subject: [PATCH 5/8] Bump `bundlesize` requirement to `v0.18.2` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index fd413235..40dd6935 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "underscore": "1.9.1" }, "devDependencies": { - "bundlesize": "^0.18.0", + "bundlesize": "^0.18.2", "coveralls": "^3.0.9", "enzyme": "^2.6.0", "husky": "^0.14.3", From d7dab46da14165ecb4b0eacba2c51310115f2e4a Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 4 Dec 2024 21:02:03 +0530 Subject: [PATCH 6/8] Try migrating to `bundlesize2` package --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 40dd6935..909a3f89 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "underscore": "1.9.1" }, "devDependencies": { - "bundlesize": "^0.18.2", + "bundlesize2": "^0.0.31", "coveralls": "^3.0.9", "enzyme": "^2.6.0", "husky": "^0.14.3", From 837ba5b1d77ef28dc90a829fe51f3599cffba03f Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Thu, 12 Dec 2024 21:21:00 +0530 Subject: [PATCH 7/8] Test with multiple versions of Node --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 64704dd9..34ae2ea8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: strategy: fail-fast: false matrix: - node_version: ["20"] + node_version: ["12", "14", "16", "18", "20"] steps: - name: Checkout Repository uses: actions/checkout@v4 From f703b4ebd58bb9f558eb80e6dad5f238364d7937 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Mon, 16 Dec 2024 17:42:56 +0530 Subject: [PATCH 8/8] Add `node-sass-7.0.3` package --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 909a3f89..2147e0ce 100644 --- a/package.json +++ b/package.json @@ -65,6 +65,7 @@ "lint-staged": "^4.3.0", "moment-locales-webpack-plugin": "^1.1.2", "nock": "10.0.6", + "node-sass": "7.0.3", "npm-run-all": "4.1.5", "prettier": "^1.19.1", "react-addons-test-utils": "15.4.1",