Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect tokenization of multiline comments with whitespace #506

Open
1 of 5 tasks
alexr00 opened this issue Sep 29, 2020 · 3 comments · May be fixed by #518
Open
1 of 5 tasks

Incorrect tokenization of multiline comments with whitespace #506

alexr00 opened this issue Sep 29, 2020 · 3 comments · May be fixed by #518
Labels
Nearly Impossible :( Things that likely need more than just Textmate matching to fix

Comments

@alexr00
Copy link

alexr00 commented Sep 29, 2020 •
edited
Loading

Checklist

  • This problem exists even with the setting "C_Cpp.enhancedColorization": "Disabled"
  • This bug exists for C
  • This bug exists for C++
  • This bug exists for Objective-C
  • This bug exists for Objective-C++

The code with a problem is:

#define TCP_NOTSENT_LOWAT	 25 /* Limit number of unsent bytes in

				       write queue.  */

#define TCP_CC_INFO		 26 /* Get Congestion Control

				       (optional) info.  */

#define TCP_SAVE_SYN		 27 /* Record SYN headers for new

				       connections.  */

#define TCP_SAVED_SYN		 28 /* Get SYN headers recorded for

				       connection.  */

It looks like:

** screenshot + theme name preferable **
image

It should look like:

Comments should span multiple lines.

Originally from @duzeev in microsoft/vscode#107565
@alexr00 alexr00 mentioned this issue Sep 29, 2020
Closed
@jeff-hykin
Copy link
Owner

I think this is unfixable without the tree sitter.

The #define uses the while pattern to ignore ranges (ranges like a { with no }), but in doing so, it ignores the range of a comment too.

@jeff-hykin jeff-hykin added the Nearly Impossible :( Things that likely need more than just Textmate matching to fix label Nov 4, 2020
@matter123
Copy link
Collaborator

@jeff-hykin Apologies for not being involved for the last 6 months.

The reason this breaks is that :single_line_macro matches as the line does not end in \

It should be possible to have :single_line_macro exclude lines that have /* that is not later succeeded by */. This would cause the macro matching to fall back to multi-line macro matching where the comment would be properly matched.

@jeff-hykin
Copy link
Owner

You're good @matter123 , I've been gone for awhile, and I probably will be intermittent at best. I've gone back to just using master since it's too much effort with the branches when I have such short time.

Thanks for the comment, I forgot there was a single line macro. Still sounds like a hack to me so I'll let you implement that one 😆. If there was a string with /* inside of it, seems like that would be a problem.

matter123 added a commit that referenced this issue Nov 6, 2020
@matter123
initial attempt at not matching comments in macros
9c4d17e 
Fixes #506.
@matter123 matter123 linked a pull request Nov 6, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Nearly Impossible :( Things that likely need more than just Textmate matching to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: initial attempt at not matching comments in macros jeff-hykin/better-cpp-syntax
3 participants
@matter123 @jeff-hykin @alexr00