Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Global prefix #1

Open
drekinov opened this issue Aug 16, 2014 · 2 comments
Open

[Proposal] Global prefix #1

drekinov opened this issue Aug 16, 2014 · 2 comments

Comments

@drekinov
Copy link

Hello,
I think it will be nice to have an option to set global prefix of all Storage Implementation.
In case you use one Redis instance/db you will have collision between settings, clients, tokens etc.
Simplest implementation could be a second constructor parameter at RedisAdapter

//RedisAdapter
 public function __construct(Client $redis, $globalPrefix = '') 

// Use
$server->setClientStorage(new Lewis\OAuth2\Server\Storage\RedisClient($redis, 'application1'));

I could try to implement it if it will be accepted as pull request

@jasonlewis
Copy link
Owner

Everything is currently prefixed with "oauth" as it stands. But I suppose some might want to have a different prefix. Perhaps implement it, but have the default as "oauth". Does that make sense?

Honestly I haven't kept up with the League's progress on this package so I don't even know if the package works with the latest development version of 4.0. Does it?

@fahmiardi
Copy link

I build new Redis Storage package support with the latest version of Alex's library (4.*), but do not have yet Unit Tests. I was inspired from this package, thanks jasonlewis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants