Uncaught TypeError: Cannot read property 'split' of undefined #259

junakmlakonja · 2018-03-15T08:32:54Z

[Enter steps to reproduce:]

Right click on js file to open git contol
tried to open git control

Atom: 1.24.1 x64
Electron: 1.6.16
OS: Microsoft Windows 7 Professional
Thrown From: git-control package 0.9.0

Stack Trace

Uncaught TypeError: Cannot read property 'split' of undefined

At C:\Users\Sara\.atom\packages\git-control\lib\git-control-view.coffee:76

TypeError: Cannot read property 'split' of undefined
    at GitControlView.module.exports.GitControlView.initialize (/packages/git-control/lib/git-control-view.coffee:76:50)
    at /packages/git-plus/node_modules/space-pen/lib/space-pen.js:184:25)
    at /packages/git-control/lib/git-control-view.coffee:36:7)
    at Object.toggleView (/packages/git-control/lib/git-control.coffee:31:18)
    at /packages/git-control/lib/git-control.coffee:18:57)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.24.1/resources/app/src/command-registry.js:388:36)
    at CommandRegistry.dispatch (~/AppData/Local/atom/app-1.24.1/resources/app/src/command-registry.js:273:23)
    at AtomEnvironment.dispatchContextMenuCommand (~/AppData/Local/atom/app-1.24.1/resources/app/src/atom-environment.js:1290:25)
    at EventEmitter.outerCallback (~/AppData/Local/atom/app-1.24.1/resources/app/src/application-delegate.js:346:31)
    at emitThree (events.js:116:13)
    at EventEmitter.emit (events.js:194:7)

Commands

     -0:56.4.0 git-control:toggle (span.syntax--markup.syntax--underline.syntax--link.syntax--http.syntax--hyperlink)

Non-Core Packages

angularjs 0.5.3 
atom-beautify 0.32.2 
auto-detect-indentation 1.3.0 
busy-signal 1.4.3 
git-control 0.9.0 
git-plus 7.10.2 
goto-definition 1.3.4 
hyperclick 0.1.5 
intentions 1.1.5 
ionic-preview 0.7.0 
js-hyperclick 1.13.0 
linter 2.2.0 
linter-jshint 3.1.6 
linter-ui-default 1.7.1 
minimap-plus 4.29.2 
open-terminal-here 2.3.1 
platformio-ide-terminal 2.8.0 
standard-formatter 2.8.0 
teletype 0.10.0

The text was updated successfully, but these errors were encountered:

Lieneke · 2018-03-26T09:32:29Z

same error here.

joe-higgins · 2018-03-27T20:16:39Z

me too

lfire · 2018-03-28T02:37:51Z

mark for me

Majestic3691 · 2018-03-29T21:17:40Z

same here

emrys57 · 2018-04-03T04:46:33Z

Identical error thrown here on Mac High Sierra

ugge77 · 2018-04-03T10:43:34Z

This error shows up unless I open a file fresh without any other files opened,

WakuwakuP · 2018-04-05T05:45:18Z

me too

igorpupkinable · 2018-04-06T14:08:29Z

Same on Ubuntu 16.04.
Atom 1.25.1 x64
git-control 0.9.0

pigpigever · 2018-04-07T17:13:23Z

I have thought my code has bugs before see this issue

wellmotta · 2018-04-11T20:40:52Z

I solved my problem creating one condition for verify the property path is exist
Changing line 76 to:

  if git.getRepository().path
     @setWorkspaceTitle(git.getRepository().path.split('/').reverse()[1])
  else
     @setWorkspaceTitle(git.getRepository().repo.workingDirectory.split('/').reverse()[0])

ghost · 2018-04-11T21:16:30Z

I can confirm that above fix by @wellmotta works for me on:

Linux pop-os 4.13.0-38-generic
Atom 1.25.1 x64

andrekutianski · 2018-04-12T16:52:26Z

same here

[Enter steps to reproduce:]

...
...

Atom: 1.24.1 x64
Electron: 1.6.16
OS: Debian GNU/Linux
Thrown From: git-control package 0.9.0

Stack Trace

Uncaught TypeError: Cannot read property 'split' of undefined

At /home/bellafronte/.atom/packages/git-control/lib/git-control-view.coffee:76

TypeError: Cannot read property 'split' of undefined
    at GitControlView.module.exports.GitControlView.initialize (/packages/git-control/lib/git-control-view.coffee:76:50)
    at /packages/git-control/node_modules/space-pen/lib/space-pen.js:184:25)
    at /packages/git-control/lib/git-control-view.coffee:36:7)
    at Object.toggleView (/packages/git-control/lib/git-control.coffee:31:14)
    at /packages/git-control/lib/git-control.coffee:18:57)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/src/command-registry.js:388:36)
    at CommandRegistry.dispatch (/usr/share/atom/resources/app/src/command-registry.js:273:23)
    at AtomEnvironment.dispatchApplicationMenuCommand (/usr/share/atom/resources/app/src/atom-environment.js:1286:25)
    at EventEmitter.outerCallback (/usr/share/atom/resources/app/src/application-delegate.js:333:31)
    at emitThree (events.js:116:13)
    at EventEmitter.emit (events.js:194:7)

Commands

     -0:51.8.0 core:confirm (input.hidden-input)
     -0:15.9.0 git-control:toggle (input.hidden-input)

Non-Core Packages

atom-beautify 0.32.2 
atom-bootstrap3 1.2.12 
busy-signal 1.4.3 
comment 0.6.1 
delete-lines 0.5.0 
emmet 2.4.3 
file-icons 2.1.18 
git-control 0.9.0 
git-gui 0.1.27 
git-plus 7.10.2 
gulp-control 0.5.0 
highlight-selected 0.13.1 
intentions 1.1.5 
language-smarty 1.8.0 
linter 2.2.0 
linter-spell 0.15.0 
linter-spell-javascript 0.9.0 
linter-ui-default 1.7.1 
markdown-img-paste 0.3.9 
markdown-pdf 2.1.0 
markdown-table-editor 1.1.0 
markdown-writer 2.7.3 
minimap 4.29.8 
minimap-highlight-selected 4.6.1 
pigments 0.40.2 
uglify 1.3.1

garrettw · 2018-04-19T14:43:00Z

@wellmotta's fix works for me as well -- please note you have to exit Atom and relaunch for the changes to take effect. Disabling and enabling the package isn't enough.

jwzhai · 2018-04-27T01:22:07Z

@wellmotta's fix is also works for me on:

MacOS 10.13
Atom 1.26.0 x64

seanidzenga · 2018-05-16T13:53:46Z

@MarcelMue @jacogr will @wellmotta's fix be implemented in the near-future?

FoxGroveMedia · 2018-05-29T13:47:55Z

@wellmotta's fix also worked for me as well.

MacOS 10.13.4
Atom 1.27.1 x64

Chinalink · 2018-06-27T02:22:12Z

@wellmotta's fix is also works for me on:

MacOS 10.13
Atom 1.28.0 x64

PointedEars · 2018-06-28T11:50:50Z

@wellmotta’s fix WFM on

Ubuntu 18.04 LTS
Atom 1.28.0. x64

@seanidzenga ISTM that @wellmotta should issue a pull request.

nikinicky · 2018-07-04T04:47:36Z

@wellmotta's fix works for me as well. thank you.

Oliver-GMJ · 2018-07-21T07:06:36Z

Windows 10 1803
Atom 1.28.3 x64

stormmao · 2018-08-19T10:23:00Z

it doesn't matter

QuentinMcCarthy · 2018-08-28T23:30:05Z

I'm also having this problem but I got @wellmotta's fix to work. With so many people having this problem and such a simple fix, why hasn't it been fixed?

lacostenycoder · 2018-08-29T22:04:29Z

I'm having the same problem, also not sure why but I sometimes get keychain wanting my password but I ignore it. Can someone explain how I can get @wellmotta 's fix to work? I see lines of code but don't know where to put them. Thanks.

QuentinMcCarthy · 2018-08-29T22:16:36Z

@lacostenycoder go to ~/.atom/packages/git-control/lib and open git-control-view.coffee. Scroll down to line 76, remove what's already there, and paste this:
if git.getRepository().path @setWorkspaceTitle(git.getRepository().path.split('/').reverse()[1]) else @setWorkspaceTitle(git.getRepository().repo.workingDirectory.split('/').reverse()[0])

Make sure the indenting is the same as everywhere else, otherwise you'll get an error. But once done, hit save, close Atom, then re-open it and you should be good. The code should end up looking like this:

lacostenycoder · 2018-08-29T22:28:51Z

@QuentinMcCarthy Thanks a lot! I see a bunch of PRs open for what look like similar solutions https://github.com/jacogr/atom-git-control/pulls

@jacogr, @MarcelMue is this repo still being maintained? Can we help?

selbyk · 2018-09-05T16:25:47Z

+1 @wellmotta's fix

tanfonto · 2018-10-14T16:17:05Z

Not that it makes a world of difference but personally, I consider runtime monkey patching safer than 3rd party source code modification so I have this guy in my init.coffee ->

atom.commands.onWillDispatch ({ type }) ->
  switch type
    { ... } # other commands
    when 'git-control:toggle'
      git = atom.project.getRepositories()[0]
      Object.defineProperty(git, 'path', {
        get: -> git.repo.workingDirectory
      }

wzbooks · 2018-10-26T08:47:49Z

@wellmotta's fix is also works for me on:

Ubuntu 14
Atom 1.26.1

Thank you

lacostenycoder · 2018-10-26T14:15:06Z

@whapky

Not that it makes a world of difference but personally, I consider runtime monkey patching safer than 3rd party source code modification so I have this guy in my init.coffee ->

Good point. However, until and unless this repo gets resurrected... but if it does, the 3rd party manipulation would get lost, right?

tanfonto · 2018-10-26T20:36:37Z

Likely. The problem I had in mind is that you may end up relying (aka building) on incompatible local changes making it very difficult to upgrade to a newer version. Not a common scenario for a top level editor package so I'm probably doomsaying though ;)

selbyk · 2018-11-14T20:19:32Z

Surprised believe this hasn't been patched yet. Wonder if @MarcelMue and @jacogr would mind adding another active maintainer

itsanjan · 2018-11-25T01:16:55Z

Still exist

QuentinMcCarthy · 2018-11-25T22:20:29Z

I actually think this repository might be dead. The last push was in May 2017. Either they're slow developers working locally only, or they're simply not maintaining this anymore.

miztizm · 2019-01-18T14:40:10Z

@lacostenycoder go to ~/.atom/packages/git-control/lib and open git-control-view.coffee. Scroll down to line 76, remove what's already there, and paste this:
if git.getRepository().path @setWorkspaceTitle(git.getRepository().path.split('/').reverse()[1]) else @setWorkspaceTitle(git.getRepository().repo.workingDirectory.split('/').reverse()[0])

i get
unexpected if in file:///C:/Users/xxxxx/.atom/packages/git-control/lib/git-control-view.coffee:76:6

garrettw · 2019-01-18T14:56:08Z

Try pasting it exactly as written -- whitespace and all.

DrewYa · 2019-03-15T00:51:28Z

solution @wellmotta 's work

wellmotta added a commit to wellmotta/atom-git-control that referenced this issue Apr 11, 2018

Fix jacogr#259

6a103e4

wellmotta mentioned this issue Apr 11, 2018

Cannot read property 'split' of undefined #254

Open

saori-morishima mentioned this issue Sep 8, 2018

OSS Gate Workshop: Tokyo: 2018-09-08: saori-morishima: atom-git-control: Work log oss-gate/workshop#945

Closed

Uncaught TypeError: Cannot read property 'split' of undefined #259

Uncaught TypeError: Cannot read property 'split' of undefined #259

Comments

junakmlakonja commented Mar 15, 2018

Stack Trace

Commands

Non-Core Packages

Lieneke commented Mar 26, 2018

joe-higgins commented Mar 27, 2018

lfire commented Mar 28, 2018

Majestic3691 commented Mar 29, 2018

emrys57 commented Apr 3, 2018

ugge77 commented Apr 3, 2018

WakuwakuP commented Apr 5, 2018

igorpupkinable commented Apr 6, 2018

pigpigever commented Apr 7, 2018

wellmotta commented Apr 11, 2018

ghost commented Apr 11, 2018

andrekutianski commented Apr 12, 2018

Stack Trace

Commands

Non-Core Packages

garrettw commented Apr 19, 2018

jwzhai commented Apr 27, 2018

seanidzenga commented May 16, 2018

FoxGroveMedia commented May 29, 2018

Chinalink commented Jun 27, 2018

PointedEars commented Jun 28, 2018 • edited Loading

nikinicky commented Jul 4, 2018

Oliver-GMJ commented Jul 21, 2018

stormmao commented Aug 19, 2018

QuentinMcCarthy commented Aug 28, 2018

lacostenycoder commented Aug 29, 2018

QuentinMcCarthy commented Aug 29, 2018 • edited Loading

lacostenycoder commented Aug 29, 2018 • edited Loading

selbyk commented Sep 5, 2018

tanfonto commented Oct 14, 2018 • edited Loading

wzbooks commented Oct 26, 2018

lacostenycoder commented Oct 26, 2018 • edited Loading

tanfonto commented Oct 26, 2018 • edited Loading

selbyk commented Nov 14, 2018

itsanjan commented Nov 25, 2018

QuentinMcCarthy commented Nov 25, 2018

miztizm commented Jan 18, 2019

garrettw commented Jan 18, 2019

DrewYa commented Mar 15, 2019

PointedEars commented Jun 28, 2018 •

edited

Loading

QuentinMcCarthy commented Aug 29, 2018 •

edited

Loading

lacostenycoder commented Aug 29, 2018 •

edited

Loading

tanfonto commented Oct 14, 2018 •

edited

Loading

lacostenycoder commented Oct 26, 2018 •

edited

Loading

tanfonto commented Oct 26, 2018 •

edited

Loading