Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-side improvements #1488

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Server-side improvements #1488

wants to merge 5 commits into from

Conversation

isc-bsaviano
Copy link
Contributor

  • Fixes Bug: server side search misses searching class member definitions #1480
  • Report search matches in the ROUTINE header and non-description comments in the class definition.
  • Improve conversion of include and exclude glob arrays to regular expressions.
  • Create an enum of supported isfs query parameters and a new helper method for getting the isfs display configurations from query parameters in a Uri. This significantly reduces the use of “magic strings”.
  • Create new helper method for getting the name of a document from an isfs Uri.
  • Create new helper method for creating a fuzzy match string to be used with the SQL LIKE predicate. Currently used to find workspace symbols and files.
  • Use new workspace connection picker for project commands.
  • Improve source control action picker prompts (see 'Server Source Control' and 'Server Command Menu' flipped after connecting to different server #1458)
  • Re-write queries for discovering server-side unit tests to improve performance.
  • Always hide .bpl and .dtl files since users can’t edit them.

gjsjohnmurray
gjsjohnmurray requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on code-reading. A couple of nits picked. I will install the dev VSIX and see if I spot any problems in daily use.

@isc-bsaviano
Copy link
Contributor Author

Thanks John!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray requested changes

@isc-rsingh isc-rsingh Awaiting requested review from isc-rsingh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: server side search misses searching class member definitions
2 participants
@isc-bsaviano @gjsjohnmurray