Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon return values are inconsitent #101

Open
dajimenezriv-internxt opened this issue Jan 25, 2025 · 0 comments
Open

Addon return values are inconsitent #101

dajimenezriv-internxt opened this issue Jan 25, 2025 · 0 comments

Comments

@dajimenezriv-internxt
Copy link
Contributor

Currently, two inconsistencies has been found in the C++ code in the addon.
The function UpdateFileIdentityWrapper returns a value that is not initialized:

Image

Or the function DisconnectSyncRoot, in which some paths do not return a value.

Image

To improve this, zod will be implemented in the virtual drive and all outputs from the addon will be check against the zod schema.
No errors will be thrown, but inconsistencies will be added to a log so we can continue to improve type safety between C++ and Typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant