Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Pass context instance to avoid breaking the tracing span #1084

Open
1 task done
septemhill opened this issue Sep 3, 2024 · 2 comments
Open
1 task done
Labels
Label sdk user-feedback vdp Created by Linear-GitHub Sync

Comments

@septemhill
Copy link

Is There an Existing Issue for This?

  • I have searched the existing issues

Where are you aiming to make improvements?

SDK

Is your Proposal Related to a Problem?

I've checked the pipeline-backend repo, there are several function may break the tracing span.

For example:

  • NewACLClient
  • NewConverter
  • RetrievePipelineUsageData

Describe Your Proposed Improvement

Add one more context field in these functions

Highlight the Benefits

No response

Anything Else?

No response

Copy link

linear bot commented Sep 3, 2024

@felixcorleone felixcorleone added sdk user-feedback vdp Created by Linear-GitHub Sync labels Sep 4, 2024 — with Linear
@kuroxx
Copy link
Collaborator

kuroxx commented Sep 5, 2024

Hello @septemhill, it's Anni from Instill AI.

Thank you for raising this issue. I have checked this with our engineering team and confirm this improvement can go into our backlog and be improved in the future.

Since the team is busy, if you decide to implement this and raise a PR, please let me know and I can sync with the team.

If you have any questions, please don't hesitate to reach out. Happy building 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Label sdk user-feedback vdp Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants