Problem recognizing new actions

[thesimonho]

In my personal config I implemented a provider to list and edit neovim options (https://github.com/thesimonho/dotfiles/blob/master/nvim/lua/utils/ui.lua#L137), and its generally working fine

I figured I would try to PR this into the main repo, in case there's any interest in such a feature

I'm having difficulty getting it to recognize the new action I created. See commit here: https://github.com/thesimonho/fzf-lua/commit/3122b129ba3c97dfc71657ed6c4f6843a26e2b40
(the provider itself is here, if it helps: https://github.com/thesimonho/fzf-lua/blob/feat/options/lua/fzf-lua/providers/nvim.lua#L438)

As far as I can tell, the only things I need to do are:

1. defaults.lua: add the default options for the provider and specify the key and action to call
2. actions.lua: add the action function itself

I must be missing something fairly basic here, as I can't get fzflua to recognize the existence of the new action, as confirmed by:

• Pressing enter on an entry just closes the window
• When I print the normalized opts that are passed through to M.options in providers/nvim.lua, the actions table shows that enter is bound to the same function as C-c and escape
• Adding [actions.option_edit] = "option-edit" to config.lua will error on neovim start as it cannot find actions.option_edit
• Binding enter to any other existing action in the codebase works fine
• Trying to bind actions.option_edit to an existing key for another provider does not work

[ibhagwan]

Looking at your code in the linked fork seems ok to me, I’m not sure why actions.option_edit is undefined, I’ll have to try your fork to figure it out, what does := FzfLua.actions.option_edit return?

[thesimonho]

its just an empty {}
FzfLua.actions shows all of the other functions fine:

  act = <function 1>,
  apply_profile = <function 2>,
  arg_add = <function 3>,
  arg_del = <function 4>,
  buf_del = <function 5>,
  buf_edit = <function 6>,
  buf_edit_or_qf = <function 7>,
  buf_sel_to_ll = <function 8>,
  buf_sel_to_qf = <function 9>,
  buf_split = <function 10>,
  buf_switch = <function 11>,
  buf_switch_or_edit = <function 12>,
  buf_tabedit = <function 13>,
  buf_vsplit = <function 14>,
  cd = <function 15>,
  colorscheme = <function 16>,
  complete = <function 17>,
  cs_delete = <function 18>,
  cs_update = <function 19>,
  dap_bp_del = <function 20>,
  dummy_abort = <function 21>,
  ex_run = <function 22>,
  ex_run_cr = <function 23>,
  exec_menu = <function 24>,
  expect = <function 25>,
  file_edit = <function 6>,
  file_edit_or_qf = <function 7>,
  file_open_in_background = <function 26>,
  file_sel_to_ll = <function 8>,
  file_sel_to_qf = <function 9>,
  file_split = <function 10>,
  file_switch = <function 11>,
  file_switch_or_edit = <function 12>,
  file_tabedit = <function 13>,
  file_vsplit = <function 14>,
  git_branch_add = <function 27>,
  git_branch_del = <function 28>,
  git_buf_edit = <function 29>,
  git_buf_split = <function 30>,
  git_buf_tabedit = <function 31>,
  git_buf_vsplit = <function 32>,
  git_checkout = <function 33>,
  git_goto_line = <function 34>,
  git_reset = <function 35>,
  git_stage = <function 36>,
  git_stage_unstage = <function 37>,
  git_stash_apply = <function 38>,
  git_stash_drop = <function 39>,
  git_stash_pop = <function 40>,
  git_switch = <function 41>,
  git_unstage = <function 42>,
  git_yank_commit = <function 43>,
  goto_jump = <function 44>,
  goto_mark = <function 45>,
  grep_lgrep = <function 46>,
  help = <function 47>,
  help_tab = <function 48>,
  help_vert = <function 49>,
  keymap_apply = <function 50>,
  keymap_edit = <function 51>,
  keymap_split = <function 52>,
  keymap_tabedit = <function 53>,
  keymap_vsplit = <function 54>,
  man = <function 55>,
  man_tab = <function 56>,
  man_vert = <function 57>,
  mark_del = <function 58>,
  normalize_selected = <function 59>,
  packadd = <function 60>,
  paste_register = <function 61>,
  resume = <function 62>,
  run_builtin = <function 63>,
  search = <function 64>,
  search_cr = <function 65>,
  set_filetype = <function 66>,
  set_qflist = <function 67>,
  spell_apply = <function 68>,
  sym_lsym = <function 69>,
  tmux_buf_set_reg = <function 70>,
  toggle_bg = <function 71>,
  toggle_flag = <function 72>,
  toggle_follow = <function 73>,
  toggle_hidden = <function 74>,
  toggle_ignore = <function 75>,
  toggle_opt = <function 76>,
  vimcmd_entry = <function 77>
}

[ibhagwan]

Something is off with your local copy? I git cloned your fork, switched to feat/options branch, := FzfLua.actions.option_edit shows a function definition and the interface help for enter shows the correct action:

[thesimonho]

very weird. i uninstalled and reinstalled everything, resetup the dev env in lazy and its fine now. thanks for double checking!

[ibhagwan]

very weird. i uninstalled and reinstalled everything, resetup the dev env in lazy and its fine now. thanks for double checking!

Feel free to PR this whenevern you feel it’s ready :)