-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5782 #5783
base: main
Are you sure you want to change the base?
Issue 5782 #5783
Conversation
…sired effect if the instructions are followed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianleeduckworth any chance you could run prettier on this real quick and then I'll land it? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the two changes needed to make this pass.
fix incorrect code format label
Description
Fixes issue where instructions for renderProps in the react-slate documentation, if followed properly, produce an undesirable effect. This PR updates instructions such that a user can re-style the placeholder while still maintaining desirable default behavior
Issue
Fixes: #5782
Example
Context
It was noticed that, when following the docs exactly, for renderProps within react-slate that the placeholder was behaving strangely. It was then noticed that in the docs the style prop that came in from
attributes
was being completely overridden. This was creating a situation where the placeholder exhibited some strange and undesirable behavior. The documentation has been updated so that theattributes
prop that comes in is extended upon instead of overwritten entirely. This allows a user to do things like change the color, opacity, etc without overwriting critical style related props.Checks
No checks necessary; only a documentation change