remove // webpack no include

[severo]

Find a way to avoid the comment here:

hyparquet/src/utils.js

Line 91 in c55a17c

const fsPackage = 'fs' // webpack no include

[platypii]

I wonder if we could fix this with a node-specific exports in package.json? So that asyncBufferFromFile only gets bundled if someone using it is targeting a nodejs environment, but not if targeted for the web?

https://nodejs.org/api/packages.html#conditional-exports

[severo]

indeed, it seems a good idea, since import('fs') will fail in a browser.

[severo]

Details in #49:

If you put await import('fs') then webpack looks at it and says "oh it looks like I need to bundle this too" but then fails because fs is a node system package not available in npm or the browser.

So the problem is not exception handling, it's the bundling.

I think that the solution is to have a conditional export. Possible that asyncBufferFromFile needs to be in its own file to avoid aggressive bundling, but not sure.
https://nodejs.org/api/packages.html#conditional-exports

I'll see if I can get a repro on the bundling issue. I think it happened when I imported from hyperparam or the cli without the string hack.