Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Badge with HA update entity shows truncated image #23857

Open
3 of 4 tasks
Mariusthvdb opened this issue Jan 23, 2025 · 3 comments
Open
3 of 4 tasks

View Badge with HA update entity shows truncated image #23857

Mariusthvdb opened this issue Jan 23, 2025 · 3 comments

Comments

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Jan 23, 2025

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.
  • I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

Image

could also be exaggerated because of the roof top shape of the icon.

Image

Describe the behavior you expected

seems the circular icon would fit those entities better?

Image

Steps to reproduce the issue

  1. use yaml from the editor screen above

...

What version of Home Assistant Core has the issue?

2025.1.3

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue?

any

Which operating system are you using to run this browser?

sequoia 15.2

State of relevant entities

Problem-relevant frontend configuration

type: entity
show_name: false
show_state: true
show_icon: true
color: ""
entity: update.home_assistant_core_update
show_entity_picture: true

Javascript errors shown in your browser console/inspector

Additional information

No response

@Mariusthvdb Mariusthvdb changed the title View Badge with update entity shows truncated image View Badge with HA update entity shows truncated image Jan 23, 2025
@ildar170975
Copy link
Contributor

ildar170975 commented Jan 28, 2025

Strange, I cannot reproduce it with my update entities:

Image

Running Container, cannot test with same entity.

@Mariusthvdb
Copy link
Contributor Author

Mariusthvdb commented Jan 28, 2025

we had he same discussion before for this image in other places. The 'new' badge wasnt available at that time, but now exhibits the same effect, because of its explicit form factor of the HA images.

in fact all if the non circular images are truncated to the circular space (check your own terminal image 2nd on the left)

If they overflow the placeholder with their image ,they'll look bad

Image

when only the background is truncated, like on HACS or Ubiquiti they look just fine:

Image

suppose this would argue for a stricter form factor requirement for the images: have the essential visual element fit within the circle.

especialy so for the HA images, which now look like those wiggly roly poly toys that always return to their upright position

@ildar170975
Copy link
Contributor

Assume we are talking about other UI elements which use state-badge.
Currently for update entity a border-radius: 0, for camera & media_player - 8%, for other domains - 50%.
Imho, if an entity has entity_picture then a state-badge element should not have border-radius: 50%, it should be more "square-ish". In this case we have a minimal amount of image lost.

The new badges are based on mushrooms which are "round-ish" - so every image has to be rounded too.
The "modern" trend of using round avatars is sick since it makes many images looking bad & forces users to adapt existing images to a smaller area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants