Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow games without an End event #63

Open
NickCondron opened this issue Mar 7, 2023 · 0 comments
Open

Allow games without an End event #63

NickCondron opened this issue Mar 7, 2023 · 0 comments

Comments

@NickCondron
Copy link
Contributor

There's a long-standing bug in Slippi where Game End events are not always written to the Slippi file (see first paragraph in spec for Game End event https://github.com/project-slippi/slippi-wiki/blob/master/SPEC.md#game-end). There are a lot of normal replay files that are only missing the game end event.

Currently, peppi fails to parse these replays into a game considering it a parse error. This behavior is sound considering the spec technically guarantees the last event to be a Game End. However, it is not useful because there are many normal games that fail to be parsed. Slippi-js parses such files without complaint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant