Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that shells within a solid don't intersect #2171

Open
hannobraun opened this issue Jan 18, 2024 · 0 comments
Open

Validate that shells within a solid don't intersect #2171

hannobraun opened this issue Jan 18, 2024 · 0 comments
Labels
topic: validation Infrastructure for checking various properties of objects, making sure they are valid. type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

Current Situation

Shell defines a boundary within a 3-dimensional space. Solid defines a solid object, which is defined as a collection of shells. These shells might be completely distinct, forming multiple bodies of the solid, or they might be nested inside of each other, forming cavities within a body.

The shells themselves must not intersect, however. That would make the solid invalid. This is neither documented nor enforced right now. We need a validation check for that.

Implementation

The new validation check would go into validate::solid. There are already other validation check there, as well as numerous more in sibling modules, which can be used as a template for the new one.

Related Issues

There are a few related issues that are currently open:

None of those issues are blockers for this one, but if work on them was ongoing by the time this issue is picked up, that would require coordination between the issues.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: validation Infrastructure for checking various properties of objects, making sure they are valid. labels Jan 18, 2024
@hannobraun hannobraun changed the title Validate the shells within a solid don't intersect Validate that shells within a solid don't intersect Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: validation Infrastructure for checking various properties of objects, making sure they are valid. type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant