Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for any/generic CI service #245

Open
Alorel opened this issue Oct 7, 2019 · 1 comment · May be fixed by #246
Open

Support for any/generic CI service #245

Alorel opened this issue Oct 7, 2019 · 1 comment · May be fixed by #246

Comments

@Alorel
Copy link

Alorel commented Oct 7, 2019

I propose adding a "generic" CI service where greenkeeper-lockfile is configured entirely by environment variables:

  • GK_LOCK_REPO_SLUG
  • GK_LOCK_BRANCH_NAME
  • GK_LOCK_FIRST_PUSH
  • GK_LOCK_CORRECT_BUILD
  • GK_LOCK_UPLOAD_BUILD

This would allow greenkeeper-lockfile to function in any environment, including Github actions. I would be happy to open a PR for this.

Considerations:

  • The generic CI service would need to be used as a fallback and ignored if any other CI is detected.

What are your thoughts on this, Greenkeeper team?
@DanielRuf
Copy link

including Github actions

That would be great.

Alorel added a commit to Alorel/greenkeeper-lockfile that referenced this issue Oct 26, 2019
@Alorel
feat: Add generic CI support
7ffc2e9 
Closes greenkeeperio#245
@Alorel Alorel linked a pull request Oct 26, 2019 that will close this issue
Open
Alorel added a commit to Alorel/greenkeeper-lockfile that referenced this issue Oct 26, 2019
@Alorel
feat: Add generic CI support
390c7de 
Closes greenkeeperio#245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add generic CI support Alorel/greenkeeper-lockfile
2 participants
@DanielRuf @Alorel