Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Swift support in buildsystem for iOS and macOS builds #10967

Open
theromis opened this issue Oct 14, 2024 · 5 comments
Open

Implement Swift support in buildsystem for iOS and macOS builds #10967

theromis opened this issue Oct 14, 2024 · 5 comments

Comments

@theromis
Copy link

Describe the project you are working on

My current project Jumpy Arcade

Describe the problem or limitation you are having in your project

After latest update SKStoreReviewController is removed from build (using it to rate app) so build is just fails, temporarily removed this call.
In last xcode it replaced by
AppStore.requestReview(in: scene)
but it exists only in SWIFT, so right now is just impossible to use this feature
https://forums.developer.apple.com/forums/thread/759918

Describe the feature / enhancement and how it helps to overcome the problem or limitation

All Apple current staff comes to swift only

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Just build SWIFT using SCONS

If this enhancement will not be used often, can it be worked around with a few lines of script?

Sounds like all code will finally switch to swift

Is there a reason why this should be core and not an add-on in the asset library?

Unfortunately swift is core build.

@AThousandShips
Copy link
Member

Just build SWIFT using SCONS

Please explain a bit more what you mean, how would this be done?

@lupuchard
Copy link

Is SwiftGodot what you're looking for?

@theromis
Copy link
Author

theromis commented Oct 14, 2024

@lupuchard unfortunately not, I need ability to build swift code as part of godot scons build (platform or modules folder)

@theromis
Copy link
Author

@AThousandShips According to this SCons/scons#4616 (comment) we can add swift here https://github.com/SCons/scons-contrib/tree/master/sconscontrib/SCons/Tool and use it as external build tool

@Calinou Calinou changed the title Add ability to use swift for Apple builds Implement Swift support in buildsystem for iOS and macOS builds Oct 15, 2024
@theromis
Copy link
Author

theromis commented Oct 30, 2024

PR created SCons/scons-contrib#53
this tool can be located inside godot repo godot_root/site_scons/site_tools/swift
and from there SConstruct will looks like this

env = Environment(tools=['default','swift'])
env.Swift('hello')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants